- Notifications
You must be signed in to change notification settings - Fork3.2k
perf: integrate go-sdk schema caching optimization (Phase 1)#1533
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Draft
Copilot wants to merge4 commits intomainChoose a base branch
base:main
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
+13 −11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Add replace directive to use github.com/SamMorrowDrums/go-sdk forkwith schema caching optimization for improved tool registration performance.Expected improvements:- 132x faster tool registration- 51x fewer allocations- 19% faster per-tool-call validationCo-authored-by: SamMorrowDrums <4811358+SamMorrowDrums@users.noreply.github.com>
CopilotAI changed the title[WIP] Integrate go-sdk schema caching optimization for performanceperf: integrate go-sdk schema caching optimization (Phase 1)Dec 4, 2025
Collaborator
SamMorrowDrums commentedDec 4, 2025
@copilot Run licenses check |
Run script/licenses to update license files after adding thereplace directive for github.com/SamMorrowDrums/go-sdk fork.Co-authored-by: SamMorrowDrums <4811358+SamMorrowDrums@users.noreply.github.com>
ContributorAuthor
CopilotAI commentedDec 4, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Ran Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
Collaborator
SamMorrowDrums commentedDec 5, 2025
Update RequiredThe upstream go-sdk PR has been cleaned up based on reviewer feedback. The input validation optimization (ApplyDefaults on structs) was removed because it's fundamentally broken per the jsonschema-go maintainer. What changed in go-sdk PR#685:
New commit to reference:replacegithub.com/modelcontextprotocol/go-sdk=>github.com/SamMorrowDrums/go-sdkv0.0.0-20251205102140-988974db6bfb The old commit Performance impact: Still get the 132x faster tool registration from schema caching, just without the per-call validation optimization (which was wrong anyway). |
The upstream go-sdk PR was cleaned up based on reviewer feedback:- Removed broken input validation optimization (ApplyDefaults on structs)- Fixed sync.Map.Clear() usage- Fixed benchmark namingNew commit 988974db6bfb contains only the schema caching optimization.
kritsada1998mt-create commentedDec 5, 2025
ghcr.io/github/github-mcp-server |
kritsada1998mt-create commentedDec 5, 2025
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
Closes:#767
Integrates schema caching optimization from go-sdk fork to eliminate expensive reflection-based schema generation on every
AddToolcall. Critical for stateless server patterns where a new server is created per HTTP request.Benchmark improvements:
Changes
replacedirective ingo.modpointing togithub.com/SamMorrowDrums/go-sdkfork with schema cachinggo.sumwith fork dependenciesscript/licensesNo code changes required—optimization is transparent to integrators.
Tradeoffs
Using a fork temporarily until the optimization is merged upstream. The fork tracks the
perf/phase1-schema-cachebranch fromSamMorrowDrums/go-sdk#1.Alternatives
Could wait for upstream merge, but the performance impact on stateless server patterns is significant enough to warrant immediate integration.
Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn moreCopilot coding agent tips in the docs.