- Notifications
You must be signed in to change notification settings - Fork3.1k
Migrate PR #1515 review threads refactoring to go-sdk#1521
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Draft
Copilot wants to merge2 commits intotonytrg/add-review-threadsChoose a base branch
base:tonytrg/add-review-threads
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Draft
Migrate PR #1515 review threads refactoring to go-sdk#1521
Copilot wants to merge2 commits intotonytrg/add-review-threadsfromcopilot/fix-merge-conflicts-get-review-comments
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Resolves merge conflicts by migrating the review threads refactoringfrom mark3labs/mcp-go to modelcontextprotocol/go-sdk:- PullRequestRead now uses getGQLClient for get_review_comments- GetPullRequestReviewComments uses GraphQL to fetch review threads- Added GraphQL types for review threads query- Updated tests and toolsnaps for new SDK patternsCo-authored-by: tonytrg <40869903+tonytrg@users.noreply.github.com>
CopilotAI changed the title[WIP] Fix merge conflicts in get_review_comments structureMigrate PR #1515 review threads refactoring to go-sdkDec 2, 2025
Copilot finished work on behalf oftonytrgDecember 2, 2025 09:50
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
Closes:#1515
Resolves merge conflicts caused by the
mark3labs/mcp-go→modelcontextprotocol/go-sdkmigration. The original PR introduced GraphQL-based review threads forget_review_commentsbut was based on the old MCP library.Changes
pkg/github/pullrequests.go:PullRequestReadnow takesgetGQLClientparameterGetPullRequestReviewCommentsuses GraphQL instead of REST APIreviewThreadsQuery,reviewThreadNode,reviewCommentNode,pageInfoFragmentpkg/github/tools.go: UpdatedPullRequestReadregistration with GraphQL clientFunctional Change (from original PR)
get_review_commentsnow returns review threads with richer metadata:{"reviewThreads": [ {"isResolved":false,"isOutdated":false,"isCollapsed":false,"comments": [...] } ],"pageInfo": {"hasNextPage":true,"endCursor":"..." },"totalCount":5}Tradeoffs: Brings in all main branch SDK migration changes (173 files) to resolve conflicts cleanly rather than cherry-picking individual changes.
Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
go.googlesource.com/update-job-proxy /update-job-proxy(dns block)go.yaml.in/update-job-proxy /update-job-proxy(dns block)gopkg.in/update-job-proxy /update-job-proxy(dns block)https://api.github.com//advisories/home/REDACTED/work/_temp/ghcca-node/node/bin/node /home/REDACTED/work/_temp/ghcca-node/node/bin/node --enable-source-maps /home/REDACTED/work/_temp/copilot-developer-action-main/dist/index.js(http block)https://api.github.com/graphql/tmp/go-build1995616253/b001/github.test /tmp/go-build1995616253/b001/github.test -test.testlogfile=/tmp/go-build1995616253/b001/testlog.txt -test.paniconexit0 -test.timeout=10m0s -test.run=Test_GetPullRequest(http block)If you need me to access, download, or install something from one of these locations, you can either:
Original prompt
✨ Let Copilot coding agentset things up for you — coding agent works faster and does higher quality work when set up for your repo.