feat: Add list_branches tool to view repository branches#151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Closed

aryasoni98 wants to merge0 commits intogithub:mainfromaryasoni98:main

Closed

feat: Add list_branches tool to view repository branches#151

aryasoni98 wants to merge0 commits intogithub:mainfromaryasoni98:main

Conversation

Copy link

Contributor

aryasoni98 commentedApr 7, 2025

Closes:#141

CopilotAI review requested due to automatic review settings

April 7, 2025 10:59

CopilotAI reviewed

Apr 7, 2025

View reviewed changes

Copy link

Contributor

CopilotAI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

pkg/github/repositories.go OutdatedShow resolvedHide resolved

juruen requested changes

Apr 7, 2025

View reviewed changes

Copy link

Collaborator

juruen left a comment•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thank so much for opening this PR! 🚀

A couple of things if you don't mind:

Could you please update the README with the new supported tool
Re: pagination, please take a look atpkg/github: fix use of per page parameter #137 which we have just merged and changed a bit how we handle pagination. If you could adopt that way of handling pagination in this PR, it'd be really great.

Thank you!

Copy link

ContributorAuthor

aryasoni98 commentedApr 7, 2025

Thank so much for opening this PR! 🚀
A couple of things if you don't mind:
Could you please update the README with the new supported tool
Re: pagination, please take a look atpkg/github: fix use of per page parameter #137 which we have just merged and changed a bit how we handle pagination. If you could adopt that way of handling pagination in this PR, it'd be really great.
Thank you!

Thank you for the review! I've addressed both points:

Added thelist_branches tool documentation to the README under the Repository section, including all parameters and their descriptions.
Updated the pagination handling to usewithPagination() helper function instead of direct parameter definitions, matching the approach used in PRpkg/github: fix use of per page parameter #137. The changes include:
- Removed explicitpage andperPage parameter definitions
- AddedwithPagination() to the tool definition
- Updated the handler to useoptionalPaginationParams for parameter extraction

All tests are passing and the code is now consistent with the project's pagination handling standards. Let me know if you'd like me to make any additional adjustments!