Summary

Fixes a panic that occurs when fetching repository resource content fails due to a network error (e.g., connection timeout, DNS failure).

Problem

InRepositoryResourceContentsHandler, the code calleddefer resp.Body.Close()before checking ifGetRawContent returned an error:

resp,err:=rawClient.GetRawContent(ctx,owner,repo,path,rawOpts)deferfunc() {_=resp.Body.Close()}()// If the raw content is not found...switch {caseerr!=nil:returnnil,fmt.Errorf("failed to get raw content: %w",err)

When a network error occurs,resp isnil, causing a panic when the deferred function tries to accessresp.Body.

Solution

Move the error checkbefore the defer statement:

resp,err:=rawClient.GetRawContent(ctx,owner,repo,path,rawOpts)iferr!=nil {returnnil,fmt.Errorf("failed to get raw content: %w",err)}deferfunc() {_=resp.Body.Close()}()

Testing

AddedTest_repositoryResourceContentsHandler_NetworkError which uses a customerrorTransport that always returns an error. This test ensures the handler gracefully handles network errors without panicking.

$ gotest ./pkg/github/... -run"Test_repositoryResource" -v=== RUN   Test_repositoryResourceContentsHandler...--- PASS: Test_repositoryResourceContentsHandler (0.01s)=== RUN   Test_repositoryResourceContentsHandler_NetworkError--- PASS: Test_repositoryResourceContentsHandler_NetworkError (0.00s)PASS

Checklist

• script/lint passes
• script/test passes
• Added test for the fix