- Notifications
You must be signed in to change notification settings - Fork3.1k
Create issue proposal for replacing go-github-mock with testify/mock#1491
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Draft
Copilot wants to merge2 commits intomainChoose a base branch fromcopilot/replace-go-github-mock
base:main
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
+114 −0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
…/mockCo-authored-by: JoannaaKL <67866556+JoannaaKL@users.noreply.github.com>
CopilotAI changed the title[WIP] Replace migueleliasweb/go-github-mock with stretchr/testifyCreate issue proposal for replacing go-github-mock with testify/mockNov 26, 2025
Copilot finished work on behalf ofJoannaaKLNovember 26, 2025 10:10
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
Closes: N/A (this PR creates the issue proposal itself)
Creates a comprehensive issue proposal document at
docs/issues/replace-go-github-mock.mdto track the migration frommigueleliasweb/go-github-mocktostretchr/testify/mock.Scope analysis:
mock.NewMockedHTTPClientcallsmock.WithRequestMatchHandlercallsKey proposal points:
githubv4mockfor GraphQL remains unchanged (out of scope)Tradeoffs:
docs/issues/directory to house issue proposals rather than using an existing location—this provides a clear home for future tracking documents.Alternatives:
Original prompt
✨ Let Copilot coding agentset things up for you — coding agent works faster and does higher quality work when set up for your repo.