Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Create issue proposal for replacing go-github-mock with testify/mock#1491

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Draft
Copilot wants to merge2 commits intomain
base:main
Choose a base branch
Loading
fromcopilot/replace-go-github-mock

Conversation

Copy link
Contributor

CopilotAI commentedNov 26, 2025
edited
Loading

Closes: N/A (this PR creates the issue proposal itself)

Creates a comprehensive issue proposal document atdocs/issues/replace-go-github-mock.md to track the migration frommigueleliasweb/go-github-mock tostretchr/testify/mock.

Scope analysis:

  • 16 files using go-github-mock
  • ~449mock.NewMockedHTTPClient calls
  • ~267mock.WithRequestMatchHandler calls
  • ~80+ unique endpoint patterns

Key proposal points:

  • Consolidate testing deps (already using testify for assertions)
  • Move from HTTP-level to interface-based mocking
  • Compile-time type safety vs runtime matching
  • githubv4mock for GraphQL remains unchanged (out of scope)

Tradeoffs:

  • Createddocs/issues/ directory to house issue proposals rather than using an existing location—this provides a clear home for future tracking documents.

Alternatives:

  • Could have created a GitHub issue directly, but documenting in-repo allows the proposal to be reviewed and refined through the PR process before becoming an official issue.
Original prompt

Create an issue to replace migueleliasweb/go-github-mock with stretchr/testify


✨ Let Copilot coding agentset things up for you — coding agent works faster and does higher quality work when set up for your repo.

…/mockCo-authored-by: JoannaaKL <67866556+JoannaaKL@users.noreply.github.com>
CopilotAI changed the title[WIP] Replace migueleliasweb/go-github-mock with stretchr/testifyCreate issue proposal for replacing go-github-mock with testify/mockNov 26, 2025
CopilotAI requested a review fromJoannaaKLNovember 26, 2025 10:10
Copilot finished work on behalf ofJoannaaKLNovember 26, 2025 10:10
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@JoannaaKLJoannaaKLAwaiting requested review from JoannaaKL

At least 1 approving review is required to merge this pull request.

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@JoannaaKL

[8]ページ先頭

©2009-2025 Movatter.jp