Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Migratepull_requests toolset to Go SDK#1466

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
omgitsads merged 4 commits intoomgitsads/go-sdkfromlulu/migrate-pullrequests
Nov 24, 2025

Conversation

@LuluBeatson
Copy link
Contributor

@LuluBeatsonLuluBeatson commentedNov 21, 2025•
edited
Loading

Closes: Part of#1428

Migrates all 10 tools from thepull_requests toolset to using modelcontextprotocol/go-sdk

@LuluBeatsonLuluBeatson changed the titleMigratepullrequests toolset to Go SDKMigratepull_requests toolset to Go SDKNov 21, 2025
@LuluBeatsonLuluBeatson marked this pull request as ready for reviewNovember 21, 2025 13:48
@LuluBeatsonLuluBeatson requested a review froma team as acode ownerNovember 21, 2025 13:48
CopilotAI review requested due to automatic review settingsNovember 21, 2025 13:48
Copilot finished reviewing on behalf ofLuluBeatsonNovember 21, 2025 13:50
Copy link
Contributor

CopilotAI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Pull Request Overview

This PR migrates all 10 tools from thepull_requests toolset to use the newmodelcontextprotocol/go-sdk instead of the oldermark3labs/mcp-go framework. The migration involves updating function signatures, schema definitions, error handling patterns, and test assertions.

Key changes:

  • Function signatures now return 3 values(*mcp.CallToolResult, any, error) instead of 2
  • Schema definitions migrated from builder pattern to directjsonschema.Schema structs
  • Error handling uses newutils.NewToolResultError helpers that setIsError: true

Reviewed Changes

Copilot reviewed 13 out of 13 changed files in this pull request and generated 1 comment.

FileDescription
pkg/github/tools.goUncommented pull requests toolset registration to enable the migrated tools
pkg/github/pullrequests.goMigrated all 10 pull request tools to new SDK with updated signatures, schemas, and error handling
pkg/github/pullrequests_test.goUpdated tests to work with new SDK: removed build ignore tag, updated schema assertions, and fixed handler call signatures
pkg/github/__toolsnaps__/*.snapUpdated 10 toolsnap files reflecting new schema structure (field order, annotations format)

@LuluBeatson
Copy link
ContributorAuthor

ScreenshotsScreenshot 2025-11-21 at 14 08 56imageimageimageimageScreenshot 2025-11-21 at 14 11 22imageimageimageimage

Copy link
Collaborator

@SamMorrowDrumsSamMorrowDrums left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

🔥

@omgitsadsomgitsads merged commit17aaf6b intoomgitsads/go-sdkNov 24, 2025
13 of 14 checks passed
@omgitsadsomgitsads deleted the lulu/migrate-pullrequests branchNovember 24, 2025 10:57
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

Copilot code reviewCopilotCopilot left review comments

@SamMorrowDrumsSamMorrowDrumsSamMorrowDrums approved these changes

@omgitsadsomgitsadsAwaiting requested review from omgitsads

Assignees

No one assigned

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@LuluBeatson@SamMorrowDrums@omgitsads
[8]ページ先頭
©2009-2025 Movatter.jp