Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Migrate Repository Resources to the Go SDK#1457

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
omgitsads merged 7 commits intoomgitsads/go-sdkfromomgitsads/go-sdk-repo-resources
Nov 20, 2025

Conversation

@omgitsads
Copy link
Member

Migrates Repository Resources to the Go SDK.

Closes:https://github.com/github/copilot-agent-services/issues/922

@omgitsadsomgitsads requested a review froma team as acode ownerNovember 20, 2025 12:46
CopilotAI review requested due to automatic review settingsNovember 20, 2025 12:46
@omgitsadsomgitsads changed the base branch frommain toomgitsads/go-sdkNovember 20, 2025 12:46
Copilot finished reviewing on behalf ofomgitsadsNovember 20, 2025 12:48
Copy link
Contributor

CopilotAI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Pull Request Overview

This PR migrates repository resource handlers from themark3labs/mcp-go SDK to the newmodelcontextprotocol/go-sdk. The migration updates API signatures, changes how URI templates are handled, and modifies how resource responses are structured.

Key Changes:

  • Updated from old MCP SDK to the official Go SDK for MCP
  • Changed URI parameter extraction from map-based arguments to URI template matching
  • Restructured resource response types to use the new SDK's format

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.

FileDescription
pkg/github/repository_resource.goMigrates resource handler functions to use new SDK types, adds URI template constants, updates parameter extraction logic, changes base64 encoding approach
pkg/github/repository_resource_test.goUpdates test structure to work with new SDK types, removes URI template validation tests, adjusts test assertions for new response format

Copy link
Collaborator

@SamMorrowDrumsSamMorrowDrums left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

😎 AFAICT stays true to original intent and looks like a clean change. Nice one.

@omgitsadsomgitsads merged commit0a19bf4 intoomgitsads/go-sdkNov 20, 2025
13 of 14 checks passed
@omgitsadsomgitsads deleted the omgitsads/go-sdk-repo-resources branchNovember 20, 2025 14:20
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

Copilot code reviewCopilotCopilot left review comments

@SamMorrowDrumsSamMorrowDrumsSamMorrowDrums approved these changes

Assignees

No one assigned

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@omgitsads@SamMorrowDrums
[8]ページ先頭
©2009-2025 Movatter.jp