Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[WIP] Partial migration of pullrequests toolset to modelcontextprotocol/go-sdk#1447

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Closed

Conversation

Copy link
Contributor

CopilotAI commentedNov 20, 2025
edited
Loading

Migrates the pullrequests toolset frommark3labs/mcp-go tomodelcontextprotocol/go-sdk. This is part of the broader SDK migration tracked in#1428.

Status

Migrated (2/10 tools):

  • PullRequestRead - 6 methods (get, get_diff, get_status, get_files, get_review_comments, get_reviews)
  • CreatePullRequest

Pending (8/10 tools): Commented out withTODO: MIGRATE THIS TOOL

  • UpdatePullRequest, ListPullRequests, MergePullRequest, SearchPullRequests, UpdatePullRequestBranch, PullRequestReviewWrite, AddCommentToPendingReview, RequestCopilotReview

Changes

Tool definition pattern:

// Old DSL-basedfuncFoo(...) (mcp.Tool, server.ToolHandlerFunc) {returnmcp.NewTool("name",mcp.WithString("param",mcp.Required(),...),...    ),handler}// New JSON Schema-basedfuncFoo(...) (mcp.Tool, mcp.ToolHandlerFor[map[string]any,any]) {tool:= mcp.Tool{Name:"name",InputSchema:&jsonschema.Schema{Type:"object",Properties:map[string]*jsonschema.Schema{"param": {Type:"string",...},            },Required: []string{"param"},        },    }handler:= mcp.ToolHandlerFor[map[string]any,any](func(ctx context.Context,_*mcp.CallToolRequest,argsmap[string]any) (*mcp.CallToolResult,any,error) {// params extracted from args map        },    )returntool,handler}

Key signature changes:

  • Handler:(ctx, request) (*Result, error)(ctx, _, args map[string]any) (*Result, any, error)
  • Parameter extraction:RequiredParam[T](request, "key")RequiredParam[T](args, "key")
  • Result construction:mcp.NewToolResultText()utils.NewToolResultText()

Notes:

  • get_comments method temporarily disabled (depends on unmigratedissues.go)
  • Helper functions return(*Result, error), handlers return(*Result, any, error)
  • search_utils.go updated to acceptargs map[string]any
Original prompt

Migrate thepullrequests toolset to modelcontextprotocol/go-sdk.

This will be merged into the parent PR#1428, so reference that PR in the description to track the migration

Custom agent used: go-sdk-tool-migrator
Agent specializing in migrating MCP tools from mark3labs/mcp-go to modelcontextprotocol/go-sdk


✨ Let Copilot coding agentset things up for you — coding agent works faster and does higher quality work when set up for your repo.

CopilotAIand others added2 commitsNovember 20, 2025 10:19
…tools completeCo-authored-by: omgitsads <4619+omgitsads@users.noreply.github.com>
…st) and fixed helper functionsCo-authored-by: omgitsads <4619+omgitsads@users.noreply.github.com>
CopilotAI changed the title[WIP] Migrate pullrequests toolset to modelcontextprotocol/go-sdk[WIP] Partial migration of pullrequests toolset to modelcontextprotocol/go-sdkNov 20, 2025
CopilotAI requested a review fromomgitsadsNovember 20, 2025 10:29
Copilot finished work on behalf ofomgitsadsNovember 20, 2025 10:29
@LuluBeatson
Copy link
Contributor

Replaced by#1466

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@omgitsadsomgitsadsAwaiting requested review from omgitsads

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@LuluBeatson@omgitsads

[8]ページ先頭

©2009-2025 Movatter.jp