- Notifications
You must be signed in to change notification settings - Fork3.1k
Migrate secret_scanning toolset to modelcontextprotocol/go-sdk#1436
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Migrate secret_scanning toolset to modelcontextprotocol/go-sdk#1436
Conversation
Co-authored-by: omgitsads <4619+omgitsads@users.noreply.github.com>
Co-authored-by: omgitsads <4619+omgitsads@users.noreply.github.com>
LuluBeatson commentedNov 19, 2025
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Pull Request Overview
This PR migrates thesecret_protection toolset frommark3labs/mcp-go tomodelcontextprotocol/go-sdk as part of a larger migration effort. It updates the implementation ofGetSecretScanningAlert andListSecretScanningAlerts tools to use the new SDK's API patterns and enables the toolset in the default toolset group.
Key changes:
- Converted DSL-style tool schemas to explicit
jsonschema.Schemastructures - Updated handler signatures to return 3 values:
(*mcp.CallToolResult, any, error) - Migrated parameter extraction from
mcp.CallToolRequesttomap[string]anyargs - Replaced
mcp.NewToolResult*helpers withutils.NewToolResult*
Reviewed Changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
pkg/github/secret_scanning.go | Migrated tool definitions and handlers from mark3labs/mcp-go to modelcontextprotocol/go-sdk API |
pkg/github/secret_scanning_test.go | Updated tests to invoke handlers with new 3-value signature and added toolsnaps validation |
pkg/github/tools.go | Uncommented secretProtection toolset registration to enable it in the default toolset group |
pkg/github/__toolsnaps__/get_secret_scanning_alert.snap | Added JSON schema snapshot for get_secret_scanning_alert tool |
pkg/github/__toolsnaps__/list_secret_scanning_alerts.snap | Added JSON schema snapshot for list_secret_scanning_alerts tool |
…igrate-secret-protection-toolset
66e6ad5 intoomgitsads/go-sdkUh oh!
There was an error while loading.Please reload this page.

Uh oh!
There was an error while loading.Please reload this page.
Closes: Part of#1428
Migrates the
secret_protectiontoolset (GetSecretScanningAlertandListSecretScanningAlerts) from mark3labs/mcp-go to modelcontextprotocol/go-sdk.Changes
jsonschema.Schemastructuresmcp.ToolHandlerFor[map[string]any, any]with 3-value returns(*mcp.CallToolResult, any, error)args map[string]anydirectly instead of extracting from requestmcp.NewToolResult*withutils.NewToolResult*secret_protectioninDefaultToolsetGroupExample of the schema migration:
Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn moreCopilot coding agent tips in the docs.