- Notifications
You must be signed in to change notification settings - Fork897
Add tools for one-off PR comments and replying to PR review comments#143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
ashwin-ant commentedApr 6, 2025
- Added two new tools for working with pull request review comments:
- add_pull_request_review_comment: Create line, multi-line, or file-level review comments (not attached to a PR review). Corresponds tothis endpoint.
- reply_to_pull_request_review_comment: Reply to existing PR review comments. Corresponds tothis endpoint.
- Verified functionality manually in MCP Insector
Adds the ability to add review comments to pull requests with support for line, multi-line, and file-level comments, as well as replying to existing comments.🤖 Generated with [Claude Code](https://claude.ai/code)Co-Authored-By: Claude <noreply@anthropic.com>
Adds a new tool to reply to existing pull request review comments using the GitHub API's comment reply endpoint. This allows for threaded discussions on pull request reviews.🤖 Generated with [Claude Code](https://claude.ai/code)Co-Authored-By: Claude <noreply@anthropic.com>
@juruen mind taking a look? Would love to get this in if possible 😄 |
104ba61 to84e6f6aCompareI manually tested this and things worked as expected.
I'd say we are good to merge! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM!
@ashwin-ant although what we have now seems to work, there's something else I'd like to explore here: the possibility of using a single tool for both cases, as I've tried to reply to a comment with that tool and hasn't worked, so I'd like us to spend a bit of time on it to try to figure that out. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Please, see my comment about trying to use a single tool for both use cases.
Thanks!
The separate AddPullRequestReviewComment and ReplyToPullRequestReviewComment tools have been merged into a single tool that handles both creating new comments and replying to existing ones. This approach simplifies the API and provides a more consistent interface for users.- Made commit_id and path optional when using in_reply_to for replies- Updated the tests to verify both comment and reply functionality- Removed the separate ReplyToPullRequestReviewComment tool- Fixed test expectations to match how errors are returned🤖 Generated with [Claude Code](https://claude.ai/code)Co-Authored-By: Claude <noreply@anthropic.com>
@juruen Updated to only have a single tool. Turns out the |
juruen commentedApr 12, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Thank you, so much! I've manually tested the latest version and works perfectly for both cases! |
6c05b40 intogithub:mainUh oh!
There was an error while loading.Please reload this page.