Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Convert tomodelcontextprotocol/go-sdk#1428

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
omgitsads wants to merge66 commits intomain
base:main
Choose a base branch
Loading
fromomgitsads/go-sdk

Conversation

@omgitsads
Copy link
Member

Replaces#1415, since Copilot Coding Agent can't do stacked PRs from a fork branch.

Switch from mark3labs/mcp-go to modelcontextprotocol/go-sdk

Closes:https://github.com/github/copilot-agent-services/issues/373

tonytrg reacted with thumbs up emoji
CopilotAIand others added3 commitsNovember 24, 2025 11:52
* Initial plan* Migrate notifications toolset to modelcontextprotocol/go-sdkCo-authored-by: omgitsads <4619+omgitsads@users.noreply.github.com>* fix the tests that Copilot removed!* re-add notifications toolset* Remove unused variables---------Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>Co-authored-by: omgitsads <4619+omgitsads@users.noreply.github.com>Co-authored-by: LuluBeatson <lulubeatson@github.com>Co-authored-by: Adam Holt <me@adamholt.co.uk>
* migrate with agent* re-add pull_requests toolset, fix whitespace* revert changes not part of migration* revert changes not part of migration
* Initial plan* Migrate actions toolset to modelcontextprotocol/go-sdk- Removed //go:build ignore tags from actions.go and actions_test.go- Updated imports to use modelcontextprotocol/go-sdk instead of mark3labs/mcp-go- Updated all tool constructor signatures to return new types- Converted all tool definitions from DSL format to jsonschema.Schema format- Updated tool handler signatures to use generics- Updated parameter extraction to use args map instead of request- Replaced mcp.NewToolResultText/Error with utils package functions- Updated all tests to work with new handler signature- Updated toolsnaps for all actions toolsCo-authored-by: omgitsads <4619+omgitsads@users.noreply.github.com>* re-add actions toolset* create toolsnaps* create toolsnaps---------Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>Co-authored-by: omgitsads <4619+omgitsads@users.noreply.github.com>Co-authored-by: LuluBeatson <lulubeatson@github.com>Co-authored-by: Adam Holt <me@adamholt.co.uk>
LuluBeatsonand others added7 commitsNovember 24, 2025 13:43
* migrate search.go* add toolsnap for search_orgs* re-add 4 search tools* Dedupe test args---------Co-authored-by: Adam Holt <me@adamholt.co.uk>
* Initial plan* Migrate projects toolset to modelcontextprotocol/go-sdkCo-authored-by: omgitsads <4619+omgitsads@users.noreply.github.com>* Update documentation after projects migrationCo-authored-by: omgitsads <4619+omgitsads@users.noreply.github.com>* Enable projects toolset after migrationCo-authored-by: omgitsads <4619+omgitsads@users.noreply.github.com>* nit: keep toolsets in original order, remove dupe* revert docs changes---------Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>Co-authored-by: omgitsads <4619+omgitsads@users.noreply.github.com>Co-authored-by: LuluBeatson <lulubeatson@github.com>
* Initial plan* WIP: Migrate repos toolset - 7/18 tools completeCo-authored-by: omgitsads <4619+omgitsads@users.noreply.github.com>* Complete repositories.go migration - all 18 tools migratedCo-authored-by: omgitsads <4619+omgitsads@users.noreply.github.com>* WIP: Update repositories_test.go - partial migrationCo-authored-by: omgitsads <4619+omgitsads@users.noreply.github.com>* Complete repos toolset migration to go-sdkCo-authored-by: omgitsads <4619+omgitsads@users.noreply.github.com>* re-add 18 tools: 15/17 repos, 3/3 stargazers* add toolsnaps for ListReleases, GetLatestRelease---------Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>Co-authored-by: omgitsads <4619+omgitsads@users.noreply.github.com>Co-authored-by: LuluBeatson <lulubeatson@github.com>Co-authored-by: Adam Holt <me@adamholt.co.uk>
Co-authored-by: SamMorrowDrums <4811358+SamMorrowDrums@users.noreply.github.com>
@LuluBeatsonLuluBeatson self-requested a reviewNovember 24, 2025 14:42
omgitsadsand others added10 commitsNovember 24, 2025 15:52
- Update imports from mark3labs/mcp-go to modelcontextprotocol/go-sdk- Update setupMCPClient to use CommandTransport and NewInMemoryTransports- Convert CallToolRequest usage to CallToolParams inline style- Update type assertions to use pointer types (*mcp.TextContent, etc.)- Update tool slice type to []*mcp.Tool- Update EmbeddedResource.Resource access (now *ResourceContents, not interface)- Update consolidated tool names (issue_write, issue_read, pull_request_read, pull_request_review_write)- Fix go-github v79 CreateTag/CreateRef API changes- Fix commitId -> commitID naming convention- Default to 'all' toolsets for comprehensive testing
…ommentSubmit- Fix TestDirectoryDeletion: Create file in test-dir/ subdirectory to  match expected filename assertion- Fix TestDirectoryDeletion: Search for deletion commit by message instead  of assuming first commit in list (order can vary)- Fix TestPullRequestReviewCommentSubmit: Relax assertion from exactly 3  comments to at least 2 (FILE-level comments may not be returned by  ListReviewComments API)
The side parameter is required for review comments but FILE-levelcomments still don't appear in ListReviewComments API results.
- FILE-level review comments: Document that they are silently dropped by  GitHub API under certain conditions and the test doesn't fully verify them- Directory deletion: Document that the test only deletes a single file  in a subdirectory, not actual recursive directory deletion
The e2e tests were migrated to modelcontextprotocol/go-sdk, so the oldSDK and its transitive dependencies are no longer needed.
Copy link
Contributor

CopilotAI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Pull request overview

Copilot reviewed 128 out of 158 changed files in this pull request and generated no new comments.

SamMorrowDrums
SamMorrowDrums previously approved these changesNov 24, 2025
Copy link
Collaborator

@SamMorrowDrumsSamMorrowDrums left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Live by the sword, die by the sword ⚔️

I think with community help for testing, and the work we put into validation already, better to get it going, get feedback and work towards release!

❤️‍🔥

Maybe in the AM though

tonytrg
tonytrg previously approved these changesNov 24, 2025
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

Copilot code reviewCopilotCopilot left review comments

@SamMorrowDrumsSamMorrowDrumsSamMorrowDrums left review comments

@tonytrgtonytrgtonytrg left review comments

@LuluBeatsonLuluBeatsonAwaiting requested review from LuluBeatson

+1 more reviewer

@notjoannaaklnotjoannaaklnotjoannaakl left review comments

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

@omgitsadsomgitsads

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@omgitsads@notjoannaakl@gigo841@SamMorrowDrums@tonytrg@LuluBeatson

[8]ページ先頭

©2009-2025 Movatter.jp