- Notifications
You must be signed in to change notification settings - Fork946
add initial tests#14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Merged
Changes fromall commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Uh oh!
There was an error while loading.Please reload this page.
Jump to
Jump to file
Failed to load files.
Loading
Uh oh!
There was an error while loading.Please reload this page.
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,230 @@ | ||
| package github | ||
| import ( | ||
| "context" | ||
| "encoding/json" | ||
| "net/http" | ||
| "testing" | ||
| "github.com/google/go-github/v69/github" | ||
| "github.com/migueleliasweb/go-github-mock/src/mock" | ||
| "github.com/stretchr/testify/assert" | ||
| "github.com/stretchr/testify/require" | ||
| ) | ||
| func Test_GetCodeScanningAlert(t *testing.T) { | ||
| // Verify tool definition once | ||
| mockClient := github.NewClient(nil) | ||
| tool, _ := getCodeScanningAlert(mockClient) | ||
| assert.Equal(t, "get_code_scanning_alert", tool.Name) | ||
| assert.NotEmpty(t, tool.Description) | ||
| assert.Contains(t, tool.InputSchema.Properties, "owner") | ||
| assert.Contains(t, tool.InputSchema.Properties, "repo") | ||
| assert.Contains(t, tool.InputSchema.Properties, "alert_number") | ||
| assert.ElementsMatch(t, tool.InputSchema.Required, []string{"owner", "repo", "alert_number"}) | ||
| // Setup mock alert for success case | ||
| mockAlert := &github.Alert{ | ||
| Number: github.Ptr(42), | ||
| State: github.Ptr("open"), | ||
| Rule: &github.Rule{ID: github.Ptr("test-rule"), Description: github.Ptr("Test Rule Description")}, | ||
| HTMLURL: github.Ptr("https://github.com/owner/repo/security/code-scanning/42"), | ||
| } | ||
| tests := []struct { | ||
| name string | ||
| mockedClient *http.Client | ||
| requestArgs map[string]interface{} | ||
| expectError bool | ||
| expectedAlert *github.Alert | ||
| expectedErrMsg string | ||
| }{ | ||
| { | ||
| name: "successful alert fetch", | ||
| mockedClient: mock.NewMockedHTTPClient( | ||
| mock.WithRequestMatch( | ||
| mock.GetReposCodeScanningAlertsByOwnerByRepoByAlertNumber, | ||
| mockAlert, | ||
| ), | ||
| ), | ||
| requestArgs: map[string]interface{}{ | ||
| "owner": "owner", | ||
| "repo": "repo", | ||
| "alert_number": float64(42), | ||
| }, | ||
| expectError: false, | ||
| expectedAlert: mockAlert, | ||
| }, | ||
| { | ||
| name: "alert fetch fails", | ||
| mockedClient: mock.NewMockedHTTPClient( | ||
| mock.WithRequestMatchHandler( | ||
| mock.GetReposCodeScanningAlertsByOwnerByRepoByAlertNumber, | ||
| http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) { | ||
| w.WriteHeader(http.StatusNotFound) | ||
| _, _ = w.Write([]byte(`{"message": "Not Found"}`)) | ||
| }), | ||
| ), | ||
| ), | ||
| requestArgs: map[string]interface{}{ | ||
| "owner": "owner", | ||
| "repo": "repo", | ||
| "alert_number": float64(9999), | ||
| }, | ||
| expectError: true, | ||
| expectedErrMsg: "failed to get alert", | ||
| }, | ||
| } | ||
| for _, tc := range tests { | ||
| t.Run(tc.name, func(t *testing.T) { | ||
| // Setup client with mock | ||
| client := github.NewClient(tc.mockedClient) | ||
| _, handler := getCodeScanningAlert(client) | ||
| // Create call request | ||
| request := createMCPRequest(tc.requestArgs) | ||
| // Call handler | ||
| result, err := handler(context.Background(), request) | ||
| // Verify results | ||
| if tc.expectError { | ||
| require.Error(t, err) | ||
| assert.Contains(t, err.Error(), tc.expectedErrMsg) | ||
| return | ||
| } | ||
| require.NoError(t, err) | ||
| // Parse the result and get the text content if no error | ||
| textContent := getTextResult(t, result) | ||
| // Unmarshal and verify the result | ||
| var returnedAlert github.Alert | ||
| err = json.Unmarshal([]byte(textContent.Text), &returnedAlert) | ||
| assert.NoError(t, err) | ||
| assert.Equal(t, *tc.expectedAlert.Number, *returnedAlert.Number) | ||
| assert.Equal(t, *tc.expectedAlert.State, *returnedAlert.State) | ||
| assert.Equal(t, *tc.expectedAlert.Rule.ID, *returnedAlert.Rule.ID) | ||
| assert.Equal(t, *tc.expectedAlert.HTMLURL, *returnedAlert.HTMLURL) | ||
| }) | ||
| } | ||
| } | ||
| func Test_ListCodeScanningAlerts(t *testing.T) { | ||
| // Verify tool definition once | ||
| mockClient := github.NewClient(nil) | ||
| tool, _ := listCodeScanningAlerts(mockClient) | ||
| assert.Equal(t, "list_code_scanning_alerts", tool.Name) | ||
| assert.NotEmpty(t, tool.Description) | ||
| assert.Contains(t, tool.InputSchema.Properties, "owner") | ||
| assert.Contains(t, tool.InputSchema.Properties, "repo") | ||
| assert.Contains(t, tool.InputSchema.Properties, "ref") | ||
| assert.Contains(t, tool.InputSchema.Properties, "state") | ||
| assert.Contains(t, tool.InputSchema.Properties, "severity") | ||
| assert.ElementsMatch(t, tool.InputSchema.Required, []string{"owner", "repo"}) | ||
| // Setup mock alerts for success case | ||
| mockAlerts := []*github.Alert{ | ||
| { | ||
| Number: github.Ptr(42), | ||
| State: github.Ptr("open"), | ||
| Rule: &github.Rule{ID: github.Ptr("test-rule-1"), Description: github.Ptr("Test Rule 1")}, | ||
| HTMLURL: github.Ptr("https://github.com/owner/repo/security/code-scanning/42"), | ||
| }, | ||
| { | ||
| Number: github.Ptr(43), | ||
| State: github.Ptr("fixed"), | ||
| Rule: &github.Rule{ID: github.Ptr("test-rule-2"), Description: github.Ptr("Test Rule 2")}, | ||
| HTMLURL: github.Ptr("https://github.com/owner/repo/security/code-scanning/43"), | ||
| }, | ||
| } | ||
| tests := []struct { | ||
| name string | ||
| mockedClient *http.Client | ||
| requestArgs map[string]interface{} | ||
| expectError bool | ||
| expectedAlerts []*github.Alert | ||
| expectedErrMsg string | ||
| }{ | ||
| { | ||
| name: "successful alerts listing", | ||
| mockedClient: mock.NewMockedHTTPClient( | ||
| mock.WithRequestMatch( | ||
| mock.GetReposCodeScanningAlertsByOwnerByRepo, | ||
| mockAlerts, | ||
| ), | ||
| ), | ||
| requestArgs: map[string]interface{}{ | ||
| "owner": "owner", | ||
| "repo": "repo", | ||
| "ref": "main", | ||
| "state": "open", | ||
| "severity": "high", | ||
| }, | ||
| expectError: false, | ||
| expectedAlerts: mockAlerts, | ||
| }, | ||
| { | ||
| name: "alerts listing fails", | ||
| mockedClient: mock.NewMockedHTTPClient( | ||
| mock.WithRequestMatchHandler( | ||
| mock.GetReposCodeScanningAlertsByOwnerByRepo, | ||
| http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) { | ||
| w.WriteHeader(http.StatusUnauthorized) | ||
| _, _ = w.Write([]byte(`{"message": "Unauthorized access"}`)) | ||
| }), | ||
| ), | ||
| ), | ||
| requestArgs: map[string]interface{}{ | ||
| "owner": "owner", | ||
| "repo": "repo", | ||
| }, | ||
| expectError: true, | ||
| expectedErrMsg: "failed to list alerts", | ||
| }, | ||
| } | ||
| for _, tc := range tests { | ||
| t.Run(tc.name, func(t *testing.T) { | ||
| // Setup client with mock | ||
| client := github.NewClient(tc.mockedClient) | ||
| _, handler := listCodeScanningAlerts(client) | ||
| // Create call request | ||
| request := createMCPRequest(tc.requestArgs) | ||
| // Call handler | ||
| result, err := handler(context.Background(), request) | ||
| // Verify results | ||
| if tc.expectError { | ||
| require.Error(t, err) | ||
| assert.Contains(t, err.Error(), tc.expectedErrMsg) | ||
| return | ||
| } | ||
| require.NoError(t, err) | ||
| // Parse the result and get the text content if no error | ||
| textContent := getTextResult(t, result) | ||
| // Unmarshal and verify the result | ||
| var returnedAlerts []*github.Alert | ||
| err = json.Unmarshal([]byte(textContent.Text), &returnedAlerts) | ||
| assert.NoError(t, err) | ||
| assert.Len(t, returnedAlerts, len(tc.expectedAlerts)) | ||
| for i, alert := range returnedAlerts { | ||
| assert.Equal(t, *tc.expectedAlerts[i].Number, *alert.Number) | ||
| assert.Equal(t, *tc.expectedAlerts[i].State, *alert.State) | ||
| assert.Equal(t, *tc.expectedAlerts[i].Rule.ID, *alert.Rule.ID) | ||
| assert.Equal(t, *tc.expectedAlerts[i].HTMLURL, *alert.HTMLURL) | ||
| } | ||
| }) | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,49 @@ | ||
| package github | ||
| import ( | ||
| "encoding/json" | ||
| "github.com/stretchr/testify/assert" | ||
| "net/http" | ||
| "testing" | ||
| "github.com/mark3labs/mcp-go/mcp" | ||
| "github.com/stretchr/testify/require" | ||
| ) | ||
| // mockResponse is a helper function to create a mock HTTP response handler | ||
| // that returns a specified status code and marshalled body. | ||
| func mockResponse(t *testing.T, code int, body interface{}) http.HandlerFunc { | ||
| t.Helper() | ||
| return func(w http.ResponseWriter, r *http.Request) { | ||
| w.WriteHeader(code) | ||
| b, err := json.Marshal(body) | ||
| require.NoError(t, err) | ||
| _, _ = w.Write(b) | ||
| } | ||
| } | ||
| // createMCPRequest is a helper function to create a MCP request with the given arguments. | ||
| func createMCPRequest(args map[string]interface{}) mcp.CallToolRequest { | ||
| return mcp.CallToolRequest{ | ||
| Params: struct { | ||
| Name string `json:"name"` | ||
| Arguments map[string]interface{} `json:"arguments,omitempty"` | ||
| Meta *struct { | ||
| ProgressToken mcp.ProgressToken `json:"progressToken,omitempty"` | ||
| } `json:"_meta,omitempty"` | ||
| }{ | ||
| Arguments: args, | ||
| }, | ||
| } | ||
| } | ||
| // getTextResult is a helper function that returns a text result from a tool call. | ||
| func getTextResult(t *testing.T, result *mcp.CallToolResult) mcp.TextContent { | ||
| t.Helper() | ||
| assert.NotNil(t, result) | ||
| require.Len(t, result.Content, 1) | ||
| require.IsType(t, mcp.TextContent{}, result.Content[0]) | ||
| textContent := result.Content[0].(mcp.TextContent) | ||
| assert.Equal(t, "text", textContent.Type) | ||
| return textContent | ||
| } |
Oops, something went wrong.
Uh oh!
There was an error while loading.Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.