Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

projects: add server instructions#1352

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

@tmelliottjr
Copy link
Contributor

This PR updates the tool/argument descriptions for projects related tools to better enable tool selection and project item filter.

Additionally, this PR introduces pagination forlist_* operations to enable effective querying.

@tmelliottjrtmelliottjr requested a review froma team as acode ownerNovember 3, 2025 18:31
CopilotAI review requested due to automatic review settingsNovember 3, 2025 18:31
Copy link
Contributor

CopilotAI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Pull Request Overview

This PR enhances the GitHub Projects V2 integration by adding advanced pagination support, improving response structures, refining query capabilities, and updating test coverage to match the new implementation. The changes focus on providing more robust pagination handling and clearer field filtering capabilities.

Key changes:

  • Added cursor-based pagination support (after,before parameters) withpageInfo in responses
  • Changed response format to includepageInfo metadata alongside data arrays
  • Updated field filtering to exclude special/system data types from responses
  • Refactored field ID handling from array to comma-separated string format

Reviewed Changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.

FileDescription
pkg/github/projects.goCore implementation: adds pagination options extraction, pageInfo builder, filterSpecialTypes function, updated response structures with pageInfo, and comprehensive query documentation
pkg/github/projects_test.goTest updates: modified mock data to include required fields (node_id), updated assertions to validate new response structure with pageInfo, simplified field query parameter handling
pkg/github/toolsnaps/*.snapSnapshot updates: documents new pagination parameters and updated descriptions for tool schemas
README.mdDocumentation updates: adds pagination parameters and extensive query syntax documentation for projects tools

💡Add Copilot custom instructions for smarter, more guided reviews.Learn how to get started.

@tmelliottjrtmelliottjr marked this pull request as draftNovember 5, 2025 01:32
@tmelliottjrtmelliottjrforce-pushed thetmelliottjr/update-projects-descriptions branch from63bbdf0 to1235e58CompareNovember 5, 2025 03:19
@tmelliottjrtmelliottjr marked this pull request as ready for reviewNovember 5, 2025 03:20
Copy link
Contributor

@kerobbikerobbi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

The technical improvements here lgtm! The only issues I can see are related to descriptions/prompts being quite verbose, and overly focused on technical details.

I have added a couple of comments just for better clarity, although they are all related to the same root concern.

Copy link
Contributor

@kerobbikerobbi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Left some comments mainly regarding reducing/optimising context usage and avoiding duplicate instructions.

I also suggested removing a lot of the query related instructions, as in general we've been finding that the model is able to construct pretty good queries using the GitHub syntax. I am curious, have you found that the model has not been able to construct queries well? If so, was it happening even for simple queries or for more complex projects ones?

@stephenotalora
Copy link
Contributor

Thanks,@kerobbi! I appreciate the feedback,@tmelliottjr is out until Monday, but I’m reviewing your comments in the meantime and will address them accordingly 🙇🏼

kerobbi reacted with heart emoji

@stephenotalorastephenotaloraforce-pushed thetmelliottjr/update-projects-descriptions branch from2ba80b8 to5cb0758CompareNovember 7, 2025 19:31
@stephenotalora
Copy link
Contributor

@tmelliottjr just an fyi, recent push is to address a number of conflicts with main

},
"per_page": {
"description":"Number of resultsper page (max100, default: 30)",
"description":"Resultsper page (max50)",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Why is that different than the default?

Copy link
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I observed the models often usingper_page: 100. Depending on the content in the payload and how many/what types of fields are requested this can result in some incredibly large response payloads. This was in service of trying to minimize that.

This along with encouraging the correct usage ofquery will hopefully reduce scenarios where truncation occurs.

Self-check before returning:
- Paginated fully
- Dedupe by id/node_id
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Why do we even need to dedupe by id? If we're listing items by id they should contain unique items already.

@tmelliottjrtmelliottjr changed the base branch frommain totmelliottjr/update-projects-toolsNovember 11, 2025 15:30
@tmelliottjrtmelliottjrforce-pushed thetmelliottjr/update-projects-descriptions branch from8f6adde to976ff67CompareNovember 11, 2025 15:41
@tmelliottjrtmelliottjr changed the titleprojects: update tools to support pagination, improve promptsprojects: add server instructionsNov 11, 2025
@tmelliottjr
Copy link
ContributorAuthor

Closed in favor of#1393

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@JoannaaKLJoannaaKLJoannaaKL left review comments

Copilot code reviewCopilotCopilot left review comments

@kerobbikerobbiAwaiting requested review from kerobbi

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@tmelliottjr@stephenotalora@JoannaaKL@kerobbi

[8]ページ先頭

©2009-2025 Movatter.jp