- Notifications
You must be signed in to change notification settings - Fork898
Clarify create_pull_request_review input schema definition for: 'position'#133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
juruen commentedApr 6, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Thank you for your contribution and for bringing this to our attention. I believe this is being addressed in#118, where we also introduce the use of new line-related parameters. Having said that, let's do some tests and see if we need to update the new description in#118 to make it succeed. Note |
Yep, that's right, should have seen that it was already being addressed 😅 |
Why
I have been playing with github's mcp server, and have found that it is incapable of adding comments due to:
This is because the current definition for the
position
input parameter is wrong:This is a clear misconception, as even the githubapi documentation states a
Note
specifying that the position is NOT the line number in the file, but of the diff.What
I have changed the description to better reflect what the input actually is. I have based it on the REST API documentation, and my tests.
How
I have used:
claude-3-5-sonnet-latest
with a simple loop:The description is a bit longer than I would have liked, but I have seen that it has a hard time understanding what this position actually means, and this has given the best results.
Alternatives