- Notifications
You must be signed in to change notification settings - Fork897
fix issue with pagination in search_repositories#129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
4e88e65 to952641bCompareThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Pull Request Overview
This PR fixes a pagination bug in the search_repositories function by ensuring the correct parameter ("perPage") is used so that the specified number of results per page is honored.
- Updated the test input in pkg/github/search_test.go from "per_page" to "perPage".
- Updated the parameter processing in pkg/github/search.go to use "perPage".
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| pkg/github/search_test.go | Changes parameter key for test input consistency. |
| pkg/github/search.go | Applies the corrected parameter key in the code. |
Tip: Copilot code review supports C#, Go, Java, JavaScript, Markdown, Python, Ruby and TypeScript, with more languages coming soon.Learn more
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Sorry, looks like I missed this one when I was mass find and replacing to do the conformance!
6b02799 intomainUh oh!
There was an error while loading.Please reload this page.
fix issue with pagination in search_repositories (github#129)
Page site tool parameter names were changed to `perPage` withingithub#129while GitHub API uses `per_page` parameter name.This change fixes overlooked inconsistencies.Follow up ongithub#129Fixesgithub#136Signed-off-by: Alexander Yastrebov <yastrebov.alex@gmail.com>
Page size tool parameter names were changed to `perPage` withingithub#129while GitHub API uses `per_page` parameter name.This change fixes overlooked inconsistencies.Follow up ongithub#129Fixesgithub#136Signed-off-by: Alexander Yastrebov <yastrebov.alex@gmail.com>
Page size tool parameter names were changed to `perPage` withingithub#90while GitHub API uses `per_page` parameter name.This change fixes overlooked inconsistencies.Follow up ongithub#90Follow up ongithub#129Fixesgithub#136Signed-off-by: Alexander Yastrebov <yastrebov.alex@gmail.com>
Page size tool parameter names were changed to `perPage` withingithub#90while GitHub API uses `per_page` parameter name.This change fixes overlooked inconsistencies.Follow up ongithub#90Follow up ongithub#129Fixesgithub#136Signed-off-by: Alexander Yastrebov <yastrebov.alex@gmail.com>
Page size tool parameter names were changed to `perPage` withingithub#90while GitHub API uses `per_page` parameter name.This change fixes overlooked inconsistencies.Follow up ongithub#90Follow up ongithub#129Fixesgithub#136Signed-off-by: Alexander Yastrebov <yastrebov.alex@gmail.com>
Uh oh!
There was an error while loading.Please reload this page.
Closes:#105
This PR makes sure that the
perPageparameter insearch_repositoriesis honored. Otherwise, we were always getting 30 results.