Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Issues consolidation#1211

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
almaleksia merged 11 commits intomainfromalmaleksia/consolidate-issues
Oct 23, 2025
Merged

Issues consolidation#1211

almaleksia merged 11 commits intomainfromalmaleksia/consolidate-issues
Oct 23, 2025

Conversation

@almaleksia
Copy link
Contributor

@almaleksiaalmaleksia commentedOct 13, 2025
edited
Loading

Consolidation of issue tools.

get_issue
get_issue_comments
list_labels (withissue_number)
list_sub_issues

are now consolidated underissue_read withmethod parameter:

get
get_comments
get_labels
get_sub_issues

create_issue
update_issue

are now consolidated underissue_write withmethod parameter:

create
update

add_sub_issue
remove_sub_issue
reprioritize_sub_issue

are consolidated undersub_issue_write withmethod parameter:

add
reprioritize
remove

Other changes:

I keptlist_labels tool but only for listing repo labels.

UPD: Changes after benchmarks and testing

  1. Addedget_comments method topull_request_read that returns PR non-review comments. Models struggle a lot distinguishing the 2 so I decided we better haveget_comments both inpull_request_read andissue_read.
  2. Added more hints for the model to distinguish review and regular comments.

@almaleksiaalmaleksiaforce-pushed thealmaleksia/consolidate-issues branch from380ada9 tod62af97CompareOctober 14, 2025 09:58
@almaleksiaalmaleksia marked this pull request as ready for reviewOctober 14, 2025 11:14
@almaleksiaalmaleksia requested a review froma team as acode ownerOctober 14, 2025 11:14
CopilotAI review requested due to automatic review settingsOctober 14, 2025 11:14
Copy link
Contributor

CopilotAI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Pull Request Overview

This PR consolidates various issue-related tools to reduce the number of exposed tools and improve consistency across the GitHub MCP server API. The changes group related operations under unified tools with amethod parameter to specify the exact action.

Key Changes:

  • Consolidates read operations (get_issue,get_issue_comments,list_sub_issues, and issue label listing) underissue_read
  • Merges write operations (create_issue andupdate_issue) underissue_write
  • Combines sub-issue operations (add_sub_issue,remove_sub_issue,reprioritize_sub_issue) undersub_issue_write

Reviewed Changes

Copilot reviewed 15 out of 15 changed files in this pull request and generated no comments.

Show a summary per file
FileDescription
pkg/github/tools.goUpdates tool registration to use consolidated tools instead of individual ones
pkg/github/labels_test.goRemoves test cases for issue-specific label listing functionality
pkg/github/labels.goSimplifies ListLabels to only handle repository labels, removing issue-specific functionality
pkg/github/issues_test.goUpdates all test cases to use consolidated tools with method parameters
pkg/github/issues.goImplements consolidated issue tools with method-based routing and extracts implementation functions
Multipletoolsnaps filesUpdates tool snapshots to reflect consolidated tool schemas
README.mdUpdates documentation to reflect the new consolidated tool structure
Comments suppressed due to low confidence (4)

pkg/github/issues.go:1

  • The required fields validation has changed from including 'title' to only requiring 'method', 'owner', 'repo'. This means title is no longer required for create operations, but the CreateIssue function still validates title is not empty. Consider adding a test case that verifies the error handling when title is missing for create method.
package github

pkg/github/issues.go:1

  • The required fields for issue_write no longer include 'issue_number', but the update method still requires it. Consider adding test coverage to verify that calling update method without issue_number parameter results in an appropriate error.
package github

pkg/github/issues.go:1

  • The parameter name has changed from 'per_page' to 'perPage' to maintain consistency with camelCase naming convention, but this should be verified against the API documentation to ensure it matches expected parameter naming.
package github

pkg/github/issues.go:1

  • There are redundant error checks - the code checksresult.IsError twice and callst.Fatalf followed byrequire.False which will never be reached if the first condition is true. Remove the redundantrequire.False(t, result.IsError) line.
package github

Tip: Customize your code reviews with copilot-instructions.md.Create the file orlearn how to get started.

@almaleksiaalmaleksiaforce-pushed thealmaleksia/consolidate-issues branch from0b98918 todb71d80CompareOctober 17, 2025 12:56
@tonytrg
Copy link
Contributor

lgtm

@tonytrgtonytrg mentioned this pull requestOct 22, 2025
@almaleksiaalmaleksia merged commit3ba8d4a intomainOct 23, 2025
16 checks passed
@almaleksiaalmaleksia deleted the almaleksia/consolidate-issues branchOctober 23, 2025 11:27
nacx added a commit to envoyproxy/ai-gateway that referenced this pull requestOct 27, 2025
**Description**GitHub has consolidated the tools related to issues, causing some of ourintegration tests to break. This PR adjusts the tests and docs to usethe new tool names.**Related Issues/PRs (if applicable)**GitHub PR:github/github-mcp-server#1211**Special notes for reviewers (if applicable)**N/ASigned-off-by: Ignasi Barrera <ignasi@tetrate.io>
Copy link

@jeuancanul1995jeuancanul1995 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Y

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

Copilot code reviewCopilotCopilot left review comments

@tonytrgtonytrgtonytrg approved these changes

+2 more reviewers

@jeuancanul1995jeuancanul1995jeuancanul1995 left review comments

@thalinda-ossthalinda-ossthalinda-oss approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@almaleksia@tonytrg@jeuancanul1995@thalinda-oss

[8]ページ先頭

©2009-2025 Movatter.jp