Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Allow unknown toolsets to be ignored#1202

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
omgitsads merged 4 commits intomainfromignore-not-found-tools
Oct 10, 2025
Merged

Conversation

omgitsads
Copy link
Member

@omgitsadsomgitsads commentedOct 10, 2025
edited
Loading

Allow unknown toolsets to be optionally ignored, rather than raising an error.

@omgitsadsomgitsads requested a review froma team as acode ownerOctober 10, 2025 08:49
@CopilotCopilotAI review requested due to automatic review settingsOctober 10, 2025 08:49
Copy link
Contributor

@CopilotCopilotAI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

func (tg*ToolsetGroup)EnableToolsets(names []string,options*EnableToolsetsOptions)error {
ifoptions==nil {
options=&EnableToolsetsOptions{
IgnoreUnknown:false,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

shall we set it to true by default?

tonytrg reacted with thumbs up emoji
almaleksia
almaleksia previously approved these changesOct 10, 2025
@omgitsadsomgitsads merged commitbcc5275 intomainOct 10, 2025
16 checks passed
@omgitsadsomgitsads deleted the ignore-not-found-tools branchOctober 10, 2025 13:21
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

Copilot code reviewCopilotCopilot left review comments

@almaleksiaalmaleksiaalmaleksia approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@omgitsads@almaleksia

[8]ページ先頭

©2009-2025 Movatter.jp