- Notifications
You must be signed in to change notification settings - Fork2.7k
rename tooling#1198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
rename tooling#1198
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Pull Request Overview
This PR renames theWriteLabel function and tool toLabelWrite to improve naming consistency. The change affects both the function name and the tool's identifier.
- Renamed function from
WriteLabeltoLabelWrite - Updated tool name from "write_label" to "label_write"
- Updated all references and documentation accordingly
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| pkg/github/tools.go | Updated function calls to use newLabelWrite name |
| pkg/github/labels_test.go | Updated test function calls and expected tool name |
| pkg/github/labels.go | Renamed function and updated translation keys |
| pkg/github/toolsnaps/label_write.snap | Updated snapshot with new tool name |
| README.md | Reorganized documentation to reflect new tool name ordering |
Tip: Customize your code reviews with copilot-instructions.md.Create the file orlearn how to get started.
| mcp.WithDescription(t("TOOL_LABEL_WRITE_DESCRIPTION","Perform write operations on repository labels. To set labels on issues, use the 'update_issue' tool.")), | ||
| mcp.WithToolAnnotation(mcp.ToolAnnotation{ | ||
| Title:t("TOOL_WRITE_LABEL_TITLE","Write operations on repository labels."), | ||
| Title:t("TOOL_LABEL_WRITE_TITLE","Write operations on repository labels."), |
CopilotAIOct 9, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
The translation keys have been updated from TOOL_WRITE_LABEL_* to TOOL_LABEL_WRITE_* but there's no evidence that the corresponding translation files have been updated. This could result in missing translations falling back to the default English text.
Copilot uses AI. Check for mistakes.
f9343e6 intomainUh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
As we named
pull_request_readandpull_request_review_writewe are sticking to that format as the read write attribute makes more sense as a suffix for better text search and formatting.And the label_write tool was accidentally added to issues too.