- Notifications
You must be signed in to change notification settings - Fork897
Add line parameter support to create_pull_request_review tool#118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
- Updated schema to make path and body the only required fields- Added line parameter as alternative to position for inline comments- Updated handler to accept either position or line based on GitHub API spec- Added new test case that verifies line parameter works properly- Updated error messages for better validation🤖 Generated with [Claude Code](https://claude.ai/code)Co-Authored-By: Claude <noreply@anthropic.com>
6fd0bb9 toe8e9edeCompare@ashwin-ant thank you so much for your contribution! We are using We should probably start using not only We can probably leave If you want to update this PR to fully support that, it'd be awesome. Otherwise, I can try to get it done at some point next week. |
- Added new parameters: line, side, start_line, start_side- Added proper validation for multi-line comment parameters- Improved validation logic to handle parameter combinations- Added test cases for regular and multi-line comments- Updated schema documentation for better tool discoverability🤖 Generated with [Claude Code](https://claude.ai/code)Co-Authored-By: Claude <noreply@anthropic.com>
e7ac2c9 to0527bc5Compare@juruen updated! How does this look? |
@ashwin-ant looks great! 😺 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM! Let's get this merged! 🚀
31471a4 intogithub:mainUh oh!
There was an error while loading.Please reload this page.
…#118)* Add line parameter support to create_pull_request_review tool- Updated schema to make path and body the only required fields- Added line parameter as alternative to position for inline comments- Updated handler to accept either position or line based on GitHub API spec- Added new test case that verifies line parameter works properly- Updated error messages for better validation🤖 Generated with [Claude Code](https://claude.ai/code)Co-Authored-By: Claude <noreply@anthropic.com>* Expand PR review API with multi-line comment support- Added new parameters: line, side, start_line, start_side- Added proper validation for multi-line comment parameters- Improved validation logic to handle parameter combinations- Added test cases for regular and multi-line comments- Updated schema documentation for better tool discoverability🤖 Generated with [Claude Code](https://claude.ai/code)Co-Authored-By: Claude <noreply@anthropic.com>* gofmt---------Co-authored-by: Claude <noreply@anthropic.com>Co-authored-by: Javier Uruen Val <juruen@github.com>
Inline comments in pull request reviews only supported
positionpreviously. This addslinesupport as well (the API requires one or the other).Closes:#112
🤖 Generated withClaude Code