- Notifications
You must be signed in to change notification settings - Fork2.7k
Improve registry release reliability#1174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:main
Are you sure you want to change the base?
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
Uh oh!
There was an error while loading.Please reload this page.
killers10 left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Dvbbhhgf
killers10 left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Evildead
| build: | ||
| runs-on:ubuntu-latest-xl | ||
| permissions: | ||
| contents:read |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Do we need to change that to contents write?
MattBabbageOct 6, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Only changes are local to 'server.json', nothing it written to repo so shouldn't require write permissions to repo itself
Uh oh!
There was an error while loading.Please reload this page.
This pull request updates the release workflow to decouple Docker image publishing from MCP Registry publication, ensuring that registry updates only occur after a successful image build and push. The workflows now communicate via a custom GitHub repository dispatch event.
Changes
Registry should be released when docker image is created -> added trigger after docker image release
Registry pipeline should check if image is released and delay if now -> add check and delay