- Notifications
You must be signed in to change notification settings - Fork2.7k
Consolidating pull requestsget tools#1172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Pull Request Overview
This PR consolidates six separate pull request read tools (get_pull_request,get_pull_request_files,get_pull_request_status,get_pull_request_diff,get_pull_request_reviews,get_pull_request_review_comments) into a single unified tool calledpull_request_read that uses amethod parameter to determine which specific operation to perform.
Key changes:
- Replaced multiple individual tools with a single consolidated
pull_request_readtool - Added method-based routing with six supported methods:
get,get_files,get_status,get_diff,get_reviews,get_review_comments - Updated all test cases to use the new consolidated tool and include the required
methodparameter
Reviewed Changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| pkg/github/tools.go | Updated toolset registration to use singlePullRequestRead tool instead of six separate tools |
| pkg/github/pullrequests_test.go | Updated all test cases to use new tool name and include requiredmethod parameter |
| pkg/github/pullrequests.go | Consolidated six separate tool functions into onePullRequestRead function with method-based routing |
| pkg/github/toolsnaps/pull_request_read.snap | Added snapshot for new consolidated tool |
| pkg/github/toolsnaps/get_*.snap | Removed snapshots for deprecated individual tools |
| README.md | Updated documentation to reflect new consolidated tool structure |
Tip: Customize your code reviews with copilot-instructions.md.Create the file orlearn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Nice!
d0d4b0e intomainUh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
This PR consolidates tools
get_pull_requestget_pull_request_filesget_pull_request_statusget_pull_request_diffget_pull_request_reviewsget_pull_request_review_commentsunder
pull_request_readwithmethodargument:getget_filesget_statusget_diffget_reviewsget_review_commentsChange has been evaluated on curated benchmarks and introduced no regressions to the current behavior accross all models.