Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Add return ID to CRUD tools#1074

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
mattdholloway merged 4 commits intomainfromadd-id-to-crud-tool-response
Sep 11, 2025
Merged

Conversation

mattdholloway
Copy link
Contributor

@mattdhollowaymattdholloway commentedSep 10, 2025
edited
Loading

This pull request updates theMinimalResponse struct to include anID field alongside the existingURL field. This change ensures that all minimal responses now return both the unique identifier and the URL for created or updated resources, making it easier for clients to reference resources directly.

  • Added anID field to theMinimalResponse struct inpkg/github/minimal_types.go, allowing API responses to include both the resource ID and URL.
  • Updated all relevant API handlers (CreateGist,UpdateGist,CreateIssue,UpdateIssue,CreatePullRequest,UpdatePullRequest,CreateRepository,ForkRepository) to set theID field in their minimal responses.[1][2][3][4][5][6][7][8]

Closes:#1071

@mattdhollowaymattdholloway requested a review froma team as acode ownerSeptember 10, 2025 16:09
@CopilotCopilotAI review requested due to automatic review settingsSeptember 10, 2025 16:09
Copy link
Contributor

@CopilotCopilotAI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Pull Request Overview

This PR updates the CRUD operations in the GitHub MCP Server to include resource IDs in minimal responses, enhancing client-side resource management. The change extends theMinimalResponse struct to include anID field alongside the existingURL field.

Key changes:

  • AddedID field toMinimalResponse struct for consistent resource identification
  • Updated all CRUD operations to populate the new ID field using the resource's GitHub ID
  • Ensured consistent formatting of IDs across different resource types

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.

Show a summary per file
FileDescription
pkg/github/minimal_types.goAdded ID field to MinimalResponse struct
pkg/github/repositories.goUpdated repository creation and fork operations to include ID
pkg/github/pullrequests.goUpdated pull request creation and update operations to include ID
pkg/github/issues.goUpdated issue creation and update operations to include ID
pkg/github/gists.goUpdated gist creation and update operations to include ID

Tip: Customize your code reviews with copilot-instructions.md.Create the file orlearn how to get started.

mattdhollowayand others added3 commitsSeptember 10, 2025 17:11
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@mattdhollowaymattdholloway self-assigned thisSep 10, 2025
@mattdhollowaymattdholloway merged commit0c5cfc3 intomainSep 11, 2025
16 checks passed
@mattdhollowaymattdholloway deleted the add-id-to-crud-tool-response branchSeptember 11, 2025 08:53
nickytonline pushed a commit to nickytonline/github-mcp-http that referenced this pull requestOct 4, 2025
* add return ID to crud tools* Update pkg/github/gists.goCo-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>* Update pkg/github/gists.goCo-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>* fix gist id to string conv---------Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

Copilot code reviewCopilotCopilot left review comments

@tonytrgtonytrgtonytrg approved these changes

Assignees

@mattdhollowaymattdholloway

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Includeid in the response ofcreate_issue
2 participants
@mattdholloway@tonytrg

[8]ページ先頭

©2009-2025 Movatter.jp