- Notifications
You must be signed in to change notification settings - Fork2.7k
Updating tool get_pull_request_comments -> get_pull_request_review_comments#1062
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
…to signify difference
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Pull Request Overview
This PR renames the toolget_pull_request_comments toget_pull_request_review_comments to better clarify its purpose. The change addresses confusion between issue comments and pull request review comments by making the tool name and description more specific.
- Renamed the tool function from
GetPullRequestCommentstoGetPullRequestReviewComments - Updated tool name from
get_pull_request_commentstoget_pull_request_review_comments - Enhanced description to clarify that these are review comments on code diffs, not general issue comments
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| pkg/github/tools.go | Updated tool registration to use the new function name |
| pkg/github/pullrequests_test.go | Updated test function calls and assertions to match the new tool name |
| pkg/github/pullrequests.go | Renamed function and updated tool definition with clearer description |
| pkg/github/toolsnaps/get_pull_request_review_comments.snap | Added snapshot file for the renamed tool |
| README.md | Updated documentation to reflect the new tool name and description |
Tip: Customize your code reviews with copilot-instructions.md.Create the file orlearn how to get started.
Uh oh!
There was an error while loading.Please reload this page.
9db2e17 intomainUh oh!
There was an error while loading.Please reload this page.
…mments (github#1062)* update get_pull_request_comments to get_pull_request_review_comments to signify difference* fix remaining old references* cleanup dangling tool snap
Uh oh!
There was an error while loading.Please reload this page.
There have been rightly so confusions about this tool by LLM and human interpretation.
This change in the tools naming and description signifies the difference between:
We are sticking closer the theofficial documentation
Closes:#735