- Notifications
You must be signed in to change notification settings - Fork897
Add support for retrieving GitHub Issue Comments#106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Add new tool 'get_issue_comments' that allows fetching comments associatedwith GitHub issues. This complements the existing issue retrieval functionalityand follows the same patterns as the pull request comments implementation.The implementation includes:- New getIssueComments function in pkg/github/issues.go- Tool registration in server.go- Comprehensive test coverage in issues_test.go
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
First of all, thank you so much for your contribution!
This is looking good, I just added a comment about adding proper pagination support.
pkg/github/issues.go Outdated
| opts := &github.IssueListCommentsOptions{ | ||
| ListOptions: github.ListOptions{ | ||
| PerPage: 100, | ||
| }, | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Please, let's add proper support for pagination. That is, let's make the tool takepage, andperPage. Take a look atlistCommits if you want to see an example.
To be consistent, use30 as the default page size.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
🤦 Great catch - I added pagination with a default perPage of 30, and added tests for it!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
This looks great, thank so much for your work here! 🚀
c77ea94 intogithub:mainUh oh!
There was an error while loading.Please reload this page.
* Add support for retrieving GitHub Issue CommentsAdd new tool 'get_issue_comments' that allows fetching comments associatedwith GitHub issues. This complements the existing issue retrieval functionalityand follows the same patterns as the pull request comments implementation.The implementation includes:- New getIssueComments function in pkg/github/issues.go- Tool registration in server.go- Comprehensive test coverage in issues_test.go* Support pagination for get_issue_comments---------Co-authored-by: Javier Uruen Val <juruen@github.com>
Add new tool 'get_issue_comments' that allows fetching comments associated with GitHub issues. This complements the existing issue retrieval functionality and follows the same patterns as the pull request comments implementation.
The implementation includes: