- Notifications
You must be signed in to change notification settings - Fork931
Open
Labels
Description
Description
On#82 (comment), I was surprised to see that my mistake did not result in a failing test. On closer inspection, it appears that there is no assertion that wecall the API with the expected values, only stubbing a response value:
github-mcp-server/pkg/github/issues_test.go
Lines 419 to 422 inbb56733
| mock.WithRequestMatchHandler( | |
| mock.PostReposIssuesByOwnerByRepo, | |
| mockResponse(t,http.StatusCreated,mockIssue), | |
| ), |
We should maybe look to tighten these tests up a bit, it would be very easy to break the tool implementations without knowing.