Commitf3414a9

committed

Extract error messages to const

1 parentaa4d088 commitf3414a9Copy full SHA for f3414a9

File tree

2 files changed

-7

lines changed

pkg/github
- projects.go
- projects_test.go

2 files changed

-7

lines changed

`‎pkg/github/projects.go‎`

Lines changed: 6 additions & 4 deletions

Original file line number	Diff line number	Diff line change
`@@ -21,6 +21,8 @@ import (`
`21`	`21`	`const (`
`22`	`22`	`ProjectUpdateFailedError="failed to update a project item"`
`23`	`23`	`ProjectAddFailedError="failed to add a project item"`
	`24`	`+ProjectDeleteFailedError="failed to delete a project item"`
	`25`	`+ProjectListFailedError="failed to list project items"`
`24`	`26`	`)`
`25`	`27`
`26`	`28`	`funcListProjects(getClientGetClientFn,t translations.TranslationHelperFunc) (tool mcp.Tool,handler server.ToolHandlerFunc) {`
`@@ -451,7 +453,7 @@ func ListProjectItems(getClient GetClientFn, t translations.TranslationHelperFun`
`451`	`453`	`resp,err:=client.Do(ctx,httpRequest,&projectItems)`
`452`	`454`	`iferr!=nil {`
`453`	`455`	`returnghErrors.NewGitHubAPIErrorResponse(ctx,`
`454`		`-"failed to list project items",`
	`456`	`+ProjectListFailedError,`
`455`	`457`	`resp,`
`456`	`458`	`err,`
`457`	`459`	`),nil`
`@@ -463,7 +465,7 @@ func ListProjectItems(getClient GetClientFn, t translations.TranslationHelperFun`
`463`	`465`	`iferr!=nil {`
`464`	`466`	`returnnil,fmt.Errorf("failed to read response body: %w",err)`
`465`	`467`	`}`
`466`		`-returnmcp.NewToolResultError(fmt.Sprintf("failed to list project items: %s",string(body))),nil`
	`468`	`+returnmcp.NewToolResultError(fmt.Sprintf("%s: %s",ProjectListFailedError,string(body))),nil`
`467`	`469`	`}`
`468`	`470`	`minimalProjectItems:= []MinimalProjectItem{}`
`469`	`471`	`for_,item:=rangeprojectItems {`
`@@ -832,7 +834,7 @@ func DeleteProjectItem(getClient GetClientFn, t translations.TranslationHelperFu`
`832`	`834`	`resp,err:=client.Do(ctx,httpRequest,nil)`
`833`	`835`	`iferr!=nil {`
`834`	`836`	`returnghErrors.NewGitHubAPIErrorResponse(ctx,`
`835`		`-"failed to delete a project item",`
	`837`	`+ProjectDeleteFailedError,`
`836`	`838`	`resp,`
`837`	`839`	`err,`
`838`	`840`	`),nil`
`@@ -844,7 +846,7 @@ func DeleteProjectItem(getClient GetClientFn, t translations.TranslationHelperFu`
`844`	`846`	`iferr!=nil {`
`845`	`847`	`returnnil,fmt.Errorf("failed to read response body: %w",err)`
`846`	`848`	`}`
`847`		`-returnmcp.NewToolResultError(fmt.Sprintf("failed to delete a project item: %s",string(body))),nil`
	`849`	`+returnmcp.NewToolResultError(fmt.Sprintf("%s: %s",ProjectDeleteFailedError,string(body))),nil`
`848`	`850`	`}`
`849`	`851`	`returnmcp.NewToolResultText("project item successfully deleted"),nil`
`850`	`852`	`}`

`‎pkg/github/projects_test.go‎`

Lines changed: 3 additions & 3 deletions

Original file line number	Diff line number	Diff line change
`@@ -697,7 +697,7 @@ func Test_ListProjectItems(t *testing.T) {`
`697`	`697`	`"project_number":float64(789),`
`698`	`698`	`},`
`699`	`699`	`expectError:true,`
`700`		`-expectedErrMsg:"failed to list project items",`
	`700`	`+expectedErrMsg:ProjectListFailedError,`
`701`	`701`	`},`
`702`	`702`	`{`
`703`	`703`	`name:"missing owner",`
`@@ -1054,7 +1054,7 @@ func Test_AddProjectItem(t *testing.T) {`
`1054`	`1054`	`"item_id":float64(8888),`
`1055`	`1055`	`},`
`1056`	`1056`	`expectError:true,`
`1057`		`-expectedErrMsg:"failed to add a project item",`
	`1057`	`+expectedErrMsg:ProjectAddFailedError,`
`1058`	`1058`	`},`
`1059`	`1059`	`{`
`1060`	`1060`	`name:"missing owner",`
`@@ -1511,7 +1511,7 @@ func Test_DeleteProjectItem(t *testing.T) {`
`1511`	`1511`	`"item_id":float64(999),`
`1512`	`1512`	`},`
`1513`	`1513`	`expectError:true,`
`1514`		`-expectedErrMsg:"failed to delete a project item",`
	`1514`	`+expectedErrMsg:ProjectDeleteFailedError,`
`1515`	`1515`	`},`
`1516`	`1516`	`{`
`1517`	`1517`	`name:"missing owner",`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commitf3414a9

File tree

2 files changed

2 files changed

`‎pkg/github/projects.go‎`

`‎pkg/github/projects_test.go‎`

0 commit comments