Commitc5ad0ac

committed

Fix: Remove invalid GetText() call on CallToolResult

Simplify workflow jobs pagination to directly handle jobs arrayinstead of trying to parse CallToolResult text content.

1 parent3a88695 commitc5ad0acCopy full SHA for c5ad0ac

File tree

1 file changed

+11

-15

lines changed

pkg/github
- actions.go

1 file changed

+11

-15

lines changed

`‎pkg/github/actions.go‎`

Lines changed: 11 additions & 15 deletions

Original file line number	Diff line number	Diff line change
`@@ -505,27 +505,23 @@ func ListWorkflowJobs(getClient GetClientFn, t translations.TranslationHelperFun`
`505`	`505`	`}`
`506`	`506`	`deferfunc() {_=resp.Body.Close() }()`
`507`	`507`
`508`		`-// Note: This response includes optimization_tip, so we need to handle it differently`
`509`		`-// For now, we'll wrap jobs in pagination and include tip separately`
`510`		`-// Get the jobs array from the response`
`511`		`-paginatedJobs,err:=CreatePaginatedResponse(jobs,pagination.Page)`
`512`		`-iferr!=nil {`
`513`		`-returnnil,err`
`514`		`-}`
`515`		`-`
`516`		`-// Parse the paginated response to add the tip`
`517`		`-varpaginatedDataPaginatedResponse`
`518`		`-iferr:=json.Unmarshal([]byte(paginatedJobs.GetText()),&paginatedData);err!=nil {`
`519`		`-returnpaginatedJobs,nil// Return as-is if parsing fails`
	`508`	`+// Handle pagination and add optimization tip`
	`509`	`+hasMore:=len(jobs.Jobs)>CursorPageSize`
	`510`	`+jobsToReturn:=jobs.Jobs`
	`511`	`+ifhasMore {`
	`512`	`+jobsToReturn=jobs.Jobs[:CursorPageSize]`
`520`	`513`	`}`
`521`	`514`
`522`	`515`	`response:=map[string]any{`
`523`		`-"items":paginatedData.Items,`
`524`		`-"moreData":paginatedData.MoreData,`
`525`		`-"cursor":paginatedData.Cursor,`
	`516`	`+"jobs":jobsToReturn,`
	`517`	`+"moreData":hasMore,`
`526`	`518`	`"optimization_tip":"For debugging failed jobs, consider using get_job_logs with failed_only=true and run_id="+fmt.Sprintf("%d",runID)+" to get logs directly without needing to list jobs first",`
`527`	`519`	`}`
`528`	`520`
	`521`	`+ifhasMore {`
	`522`	`+response["cursor"]=EncodeCursor(pagination.Page+1)`
	`523`	`+}`
	`524`	`+`
`529`	`525`	`r,err:=json.Marshal(response)`
`530`	`526`	`iferr!=nil {`
`531`	`527`	`returnnil,fmt.Errorf("failed to marshal response: %w",err)`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commitc5ad0ac

File tree

1 file changed

1 file changed

`‎pkg/github/actions.go‎`

0 commit comments