Commit86fbc85

authored

Fix handling nil values for optional string array parameters, (#194)

* Fix handling nil values for optional string array parameters,nil values should be equivalent to an empty string, currently we return an error but Claude passes nil for optional values.* lint fixes

1 parent56c1fce commit86fbc85Copy full SHA for 86fbc85

File tree

2 files changed

-3

lines changed

pkg/github
- issues_test.go
- server.go

2 files changed

-3

lines changed

`‎pkg/github/issues_test.go`

Lines changed: 4 additions & 3 deletions

Original file line number	Diff line number	Diff line change
`@@ -468,9 +468,10 @@ func Test_CreateIssue(t *testing.T) {`
`468`	`468`	`),`
`469`	`469`	`),`
`470`	`470`	`requestArgs:map[string]interface{}{`
`471`		`-"owner":"owner",`
`472`		`-"repo":"repo",`
`473`		`-"title":"Minimal Issue",`
	`471`	`+"owner":"owner",`
	`472`	`+"repo":"repo",`
	`473`	`+"title":"Minimal Issue",`
	`474`	`+"assignees":nil,// Expect no failure with nil optional value.`
`474`	`475`	`},`
`475`	`476`	`expectError:false,`
`476`	`477`	`expectedIssue:&github.Issue{`

`‎pkg/github/server.go`

Lines changed: 2 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -238,6 +238,8 @@ func OptionalStringArrayParam(r mcp.CallToolRequest, p string) ([]string, error)`
`238`	`238`	`}`
`239`	`239`
`240`	`240`	`switchv:=r.Params.Arguments[p].(type) {`
	`241`	`+casenil:`
	`242`	`+return []string{},nil`
`241`	`243`	`case []string:`
`242`	`244`	`returnv,nil`
`243`	`245`	`case []any:`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit86fbc85

File tree

2 files changed

2 files changed

`‎pkg/github/issues_test.go`

`‎pkg/github/server.go`

0 commit comments