Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Commit84e6f6a

Browse files
committed
rebase
1 parentb79abbe commit84e6f6a

File tree

3 files changed

+17
-10
lines changed

3 files changed

+17
-10
lines changed

‎github-mcp-server

11.3 MB
Binary file not shown.

‎pkg/github/pullrequests.go

Lines changed: 6 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -558,7 +558,7 @@ func AddPullRequestReviewComment(client *github.Client, t translations.Translati
558558
iferr!=nil {
559559
returnmcp.NewToolResultError(err.Error()),nil
560560
}
561-
pullNumber,err:=requiredInt(request,"pull_number")
561+
pullNumber,err:=RequiredInt(request,"pull_number")
562562
iferr!=nil {
563563
returnmcp.NewToolResultError(err.Error()),nil
564564
}
@@ -586,14 +586,13 @@ func AddPullRequestReviewComment(client *github.Client, t translations.Translati
586586
comment.InReplyTo=github.Ptr(int64(replyToFloat))
587587
}else {
588588
// Handle subject_type parameter
589-
subjectType,err:=optionalParam[string](request,"subject_type")
589+
subjectType,err:=OptionalParam[string](request,"subject_type")
590590
iferr!=nil {
591591
returnmcp.NewToolResultError(err.Error()),nil
592592
}
593-
ifsubjectType=="file" {
594-
// When commenting on a file, no line/position fields are needed
595-
}else {
593+
ifsubjectType!="file" {
596594
// Handle line or position-based comments
595+
// No action needed if subjectType is "file"
597596
line,lineExists:=request.Params.Arguments["line"].(float64)
598597
startLine,startLineExists:=request.Params.Arguments["start_line"].(float64)
599598
side,sideExists:=request.Params.Arguments["side"].(string)
@@ -684,11 +683,11 @@ func ReplyToPullRequestReviewComment(client *github.Client, t translations.Trans
684683
iferr!=nil {
685684
returnmcp.NewToolResultError(err.Error()),nil
686685
}
687-
pullNumber,err:=requiredInt(request,"pull_number")
686+
pullNumber,err:=RequiredInt(request,"pull_number")
688687
iferr!=nil {
689688
returnmcp.NewToolResultError(err.Error()),nil
690689
}
691-
commentID,err:=requiredInt(request,"comment_id")
690+
commentID,err:=RequiredInt(request,"comment_id")
692691
iferr!=nil {
693692
returnmcp.NewToolResultError(err.Error()),nil
694693
}

‎pkg/github/pullrequests_test.go

Lines changed: 11 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1575,7 +1575,11 @@ func Test_AddPullRequestReviewComment(t *testing.T) {
15751575
mock.PostReposPullsCommentsByOwnerByRepoByPullNumber,
15761576
http.HandlerFunc(func(w http.ResponseWriter,_*http.Request) {
15771577
w.WriteHeader(http.StatusCreated)
1578-
json.NewEncoder(w).Encode(mockComment)
1578+
err:=json.NewEncoder(w).Encode(mockComment)
1579+
iferr!=nil {
1580+
http.Error(w,err.Error(),http.StatusInternalServerError)
1581+
return
1582+
}
15791583
}),
15801584
),
15811585
),
@@ -1686,7 +1690,11 @@ func Test_ReplyToPullRequestReviewComment(t *testing.T) {
16861690
mock.PostReposPullsCommentsByOwnerByRepoByPullNumber,
16871691
http.HandlerFunc(func(w http.ResponseWriter,_*http.Request) {
16881692
w.WriteHeader(http.StatusCreated)
1689-
json.NewEncoder(w).Encode(mockReply)
1693+
err:=json.NewEncoder(w).Encode(mockReply)
1694+
iferr!=nil {
1695+
http.Error(w,err.Error(),http.StatusInternalServerError)
1696+
return
1697+
}
16901698
}),
16911699
),
16921700
),
@@ -1728,7 +1736,7 @@ func Test_ReplyToPullRequestReviewComment(t *testing.T) {
17281736
t.Run(tc.name,func(t*testing.T) {
17291737
mockClient:=github.NewClient(tc.mockedClient)
17301738

1731-
_,handler:=replyToPullRequestReviewComment(mockClient,translations.NullTranslationHelper)
1739+
_,handler:=ReplyToPullRequestReviewComment(mockClient,translations.NullTranslationHelper)
17321740

17331741
request:=createMCPRequest(tc.requestArgs)
17341742

0 commit comments

Comments
 (0)
[8]ページ先頭
©2009-2025 Movatter.jp