Commit834f0fa

committed

Switch to getClient idiom

1 parenteb706e8 commit834f0faCopy full SHA for 834f0fa

File tree

-5

lines changed

-5

lines changed

Lines changed: 6 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -13,7 +13,7 @@ import (`
`13`	`13`	`)`
`14`	`14`
`15`	`15`	`// ListCommits creates a tool to get commits of a branch in a repository.`
`16`		`-funcListRepositories(client*github.Client,t translations.TranslationHelperFunc) (tool mcp.Tool,handler server.ToolHandlerFunc) {`
	`16`	`+funcListRepositories(getClientGetClientFn,t translations.TranslationHelperFunc) (tool mcp.Tool,handler server.ToolHandlerFunc) {`
`17`	`17`	`returnmcp.NewTool("list_repositories",`
`18`	`18`	`mcp.WithDescription(t("TOOL_LIST_REPOSITORIES_DESCRIPTION","Get list of repositories in a GitHub organization")),`
`19`	`19`	`mcp.WithString("org",`
`@@ -70,6 +70,11 @@ func ListRepositories(client *github.Client, t translations.TranslationHelperFun`
`70`	`70`	`opts.Direction=direction`
`71`	`71`	`}`
`72`	`72`
	`73`	`+client,err:=getClient(ctx)`
	`74`	`+iferr!=nil {`
	`75`	`+returnnil,fmt.Errorf("failed to get GitHub client: %w",err)`
	`76`	`+}`
	`77`	`+`
`73`	`78`	`repos,resp,err:=client.Repositories.ListByOrg(ctx,org,opts)`
`74`	`79`	`iferr!=nil {`
`75`	`80`	`returnnil,fmt.Errorf("failed to list repositories: %w",err)`

Lines changed: 2 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -16,7 +16,7 @@ import (`
`16`	`16`	`funcTest_ListRepositories(t*testing.T) {`
`17`	`17`	`// Verify tool definition once`
`18`	`18`	`mockClient:=github.NewClient(nil)`
`19`		`-tool,_:=ListRepositories(mockClient,translations.NullTranslationHelper)`
	`19`	`+tool,_:=ListRepositories(stubGetClientFn(mockClient),translations.NullTranslationHelper)`
`20`	`20`
`21`	`21`	`assert.Equal(t,"list_repositories",tool.Name)`
`22`	`22`	`assert.NotEmpty(t,tool.Description)`
`@@ -172,7 +172,7 @@ func Test_ListRepositories(t *testing.T) {`
`172`	`172`	`t.Run(tc.name,func(t*testing.T) {`
`173`	`173`	`// Setup client with mock`
`174`	`174`	`client:=github.NewClient(tc.mockedClient)`
`175`		`-_,handler:=ListRepositories(client,translations.NullTranslationHelper)`
	`175`	`+_,handler:=ListRepositories(stubGetClientFn(client),translations.NullTranslationHelper)`
`176`	`176`
`177`	`177`	`// Create call request`
`178`	`178`	`request:=createMCPRequest(tc.requestArgs)`

Lines changed: 1 addition & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -80,7 +80,7 @@ func NewServer(getClient GetClientFn, version string, readOnly bool, t translati`
`80`	`80`	`}`
`81`	`81`
`82`	`82`	`// Add GitHub tools - Organizations`
`83`		`-s.AddTool(ListRepositories(client,t))`
	`83`	`+s.AddTool(ListRepositories(getClient,t))`
`84`	`84`
`85`	`85`	`// Add GitHub tools - Search`
`86`	`86`	`s.AddTool(SearchCode(getClient,t))`
`@@ -181,7 +181,6 @@ func requiredParam[T comparable](r mcp.CallToolRequest, p string) (T, error) {`
`181`	`181`
`182`	`182`	`ifr.Params.Arguments[p].(T)==zero {`
`183`	`183`	`returnzero,fmt.Errorf("missing required parameter: %s",p)`
`184`		`-`
`185`	`184`	`}`
`186`	`185`
`187`	`186`	`returnr.Params.Arguments[p].(T),nil`

Comments

(0)