Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Commit63d3d8c

Browse files
authored
fix: use ENTRYPOINT and CMD for proper argument handling (#454)
* fix: use ENTRYPOINT and CMD for proper argument handling- Change from CMD to ENTRYPOINT + CMD pattern for better Docker practices- ENTRYPOINT sets the executable that always runs- CMD provides default arguments that can be overridden- This allows container runtimes to properly append additional arguments- Fixes issues with argument passing in container orchestration toolsBefore: CMD ["./github-mcp-server", "stdio"]After: ENTRYPOINT ["./github-mcp-server"] + CMD ["stdio"]* address review feedback: use absolute path and improve comments
1 parentc7a872b commit63d3d8c

File tree

1 file changed

+4
-2
lines changed

1 file changed

+4
-2
lines changed

‎Dockerfile

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -22,5 +22,7 @@ FROM gcr.io/distroless/base-debian12
2222
WORKDIR /server
2323
# Copy the binary from the build stage
2424
COPY --from=build /bin/github-mcp-server .
25-
# Command to run the server
26-
CMD ["./github-mcp-server","stdio"]
25+
# Set the entrypoint to the server binary
26+
ENTRYPOINT ["/server/github-mcp-server"]
27+
# Default arguments for ENTRYPOINT
28+
CMD ["stdio"]

0 commit comments

Comments
 (0)
[8]ページ先頭
©2009-2025 Movatter.jp