Commit37d1ed6

authored and

committed

return MinimalUser

1 parent6c0453a commit37d1ed6Copy full SHA for 37d1ed6

File tree

+16

-11

lines changed

+16

-11

lines changed

Lines changed: 12 additions & 3 deletions

Original file line number	Diff line number	Diff line change
`@@ -38,10 +38,19 @@ func GetMe(getClient GetClientFn, t translations.TranslationHelperFunc) (mcp.Too`
`38`	`38`	`),nil`
`39`	`39`	`}`
`40`	`40`
`41`		`-// Set nil to omit from output`
`42`		`-user.SiteAdmin=nil`
	`41`	`+// Create minimal user representation instead of returning full user object`
	`42`	`+minimalUser:=MinimalUser{`
	`43`	`+Login:user.GetLogin(),`
	`44`	`+ID:user.GetID(),`
	`45`	`+}`
	`46`	`+ifuser.HTMLURL!=nil {`
	`47`	`+minimalUser.ProfileURL=*user.HTMLURL`
	`48`	`+}`
	`49`	`+ifuser.AvatarURL!=nil {`
	`50`	`+minimalUser.AvatarURL=*user.AvatarURL`
	`51`	`+}`
`43`	`52`
`44`		`-returnMarshalledTextResult(user),nil`
	`53`	`+returnMarshalledTextResult(minimalUser),nil`
`45`	`54`	`})`
`46`	`55`
`47`	`56`	`returntool,handler`

Lines changed: 4 additions & 8 deletions

Original file line number	Diff line number	Diff line change
`@@ -117,17 +117,13 @@ func Test_GetMe(t *testing.T) {`
`117`	`117`	`}`
`118`	`118`
`119`	`119`	`// Unmarshal and verify the result`
`120`		`-varreturnedUsergithub.User`
	`120`	`+varreturnedUserMinimalUser`
`121`	`121`	`err=json.Unmarshal([]byte(textContent.Text),&returnedUser)`
`122`	`122`	`require.NoError(t,err)`
`123`	`123`
`124`		`-// Verify user details`
`125`		`-assert.Equal(t,tc.expectedUser.Login,returnedUser.Login)`
`126`		`-assert.Equal(t,tc.expectedUser.Name,returnedUser.Name)`
`127`		`-assert.Equal(t,tc.expectedUser.Email,returnedUser.Email)`
`128`		`-assert.Equal(t,tc.expectedUser.Bio,returnedUser.Bio)`
`129`		`-assert.Equal(t,tc.expectedUser.HTMLURL,returnedUser.HTMLURL)`
`130`		`-assert.Equal(t,tc.expectedUser.Type,returnedUser.Type)`
	`124`	`+// Verify minimal user details`
	`125`	`+assert.Equal(t,*tc.expectedUser.Login,returnedUser.Login)`
	`126`	`+assert.Equal(t,*tc.expectedUser.HTMLURL,returnedUser.ProfileURL)`
`131`	`127`	`})`
`132`	`128`	`}`
`133`	`129`	`}`

Comments

(0)