Commit32b0231

and

committed

Fix more test response parsing - notifications, pull requests, and discussions

Co-authored-by: SamMorrowDrums <4811358+SamMorrowDrums@users.noreply.github.com>

1 parentc64cfdc commit32b0231Copy full SHA for 32b0231

File tree

+24

-9

lines changed

+24

-9

lines changed

Lines changed: 8 additions & 7 deletions

Original file line number	Diff line number	Diff line change
`@@ -442,17 +442,18 @@ func Test_ListDiscussions(t *testing.T) {`
`442`	`442`	`require.NoError(t,err)`
`443`	`443`
`444`	`444`	`// Parse the structured response with pagination info`
	`445`	`+varpaginatedResponsePaginatedResponse`
	`446`	`+err=json.Unmarshal([]byte(text),&paginatedResponse)`
	`447`	`+require.NoError(t,err)`
	`448`	`+`
	`449`	`+// The data field contains the response`
	`450`	`+dataBytes,err:=json.Marshal(paginatedResponse.Data)`
	`451`	`+require.NoError(t,err)`
`445`	`452`	`varresponsestruct {`
`446`	`453`	Discussions []*github.Discussion`json:"discussions"`
`447`		`-PageInfostruct {`
`448`		-HasNextPagebool`json:"hasNextPage"`
`449`		-HasPreviousPagebool`json:"hasPreviousPage"`
`450`		-StartCursorstring`json:"startCursor"`
`451`		-EndCursorstring`json:"endCursor"`
`452`		-}`json:"pageInfo"`
`453`	`454`	TotalCountint`json:"totalCount"`
`454`	`455`	`}`
`455`		`-err=json.Unmarshal([]byte(text),&response)`
	`456`	`+err=json.Unmarshal(dataBytes,&response)`
`456`	`457`	`require.NoError(t,err)`
`457`	`458`
`458`	`459`	`assert.Len(t,response.Discussions,tc.expectedCount,"Expected %d discussions, got %d",tc.expectedCount,len(response.Discussions))`

Lines changed: 8 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -139,8 +139,15 @@ func Test_ListNotifications(t *testing.T) {`
`139`	`139`	`require.False(t,result.IsError)`
`140`	`140`	`textContent:=getTextResult(t,result)`
`141`	`141`	`t.Logf("textContent: %s",textContent.Text)`
	`142`	`+varpaginatedResponsePaginatedResponse`
	`143`	`+err=json.Unmarshal([]byte(textContent.Text),&paginatedResponse)`
	`144`	`+require.NoError(t,err)`
	`145`	`+`
	`146`	`+// The data field contains the notifications`
	`147`	`+dataBytes,err:=json.Marshal(paginatedResponse.Data)`
	`148`	`+require.NoError(t,err)`
`142`	`149`	`varreturned []*github.Notification`
`143`		`-err=json.Unmarshal([]byte(textContent.Text),&returned)`
	`150`	`+err=json.Unmarshal(dataBytes,&returned)`
`144`	`151`	`require.NoError(t,err)`
`145`	`152`	`require.NotEmpty(t,returned)`
`146`	`153`	`assert.Equal(t,tc.expectedResult[0].ID,returned[0].ID)`

Lines changed: 8 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -694,8 +694,15 @@ func Test_ListPullRequests(t *testing.T) {`
`694`	`694`	`textContent:=getTextResult(t,result)`
`695`	`695`
`696`	`696`	`// Unmarshal and verify the result`
	`697`	`+varpaginatedResponsePaginatedResponse`
	`698`	`+err=json.Unmarshal([]byte(textContent.Text),&paginatedResponse)`
	`699`	`+require.NoError(t,err)`
	`700`	`+`
	`701`	`+// The data field contains the pull requests`
	`702`	`+dataBytes,err:=json.Marshal(paginatedResponse.Data)`
	`703`	`+require.NoError(t,err)`
`697`	`704`	`varreturnedPRs []*github.PullRequest`
`698`		`-err=json.Unmarshal([]byte(textContent.Text),&returnedPRs)`
	`705`	`+err=json.Unmarshal(dataBytes,&returnedPRs)`
`699`	`706`	`require.NoError(t,err)`
`700`	`707`	`assert.Len(t,returnedPRs,2)`
`701`	`708`	`assert.Equal(t,tc.expectedPRs[0].Number,returnedPRs[0].Number)`

Comments

(0)