Commit1d057c9

authored and

committed

refactor: user get methods to avoid nil checks

1 parent37d1ed6 commit1d057c9Copy full SHA for 1d057c9

File tree

-17

lines changed

-17

lines changed

Lines changed: 4 additions & 8 deletions

Original file line number	Diff line number	Diff line change
`@@ -40,14 +40,10 @@ func GetMe(getClient GetClientFn, t translations.TranslationHelperFunc) (mcp.Too`
`40`	`40`
`41`	`41`	`// Create minimal user representation instead of returning full user object`
`42`	`42`	`minimalUser:=MinimalUser{`
`43`		`-Login:user.GetLogin(),`
`44`		`-ID:user.GetID(),`
`45`		`-}`
`46`		`-ifuser.HTMLURL!=nil {`
`47`		`-minimalUser.ProfileURL=*user.HTMLURL`
`48`		`-}`
`49`		`-ifuser.AvatarURL!=nil {`
`50`		`-minimalUser.AvatarURL=*user.AvatarURL`
	`43`	`+Login:user.GetLogin(),`
	`44`	`+ID:user.GetID(),`
	`45`	`+ProfileURL:user.GetHTMLURL(),`
	`46`	`+AvatarURL:user.GetAvatarURL(),`
`51`	`47`	`}`
`52`	`48`
`53`	`49`	`returnMarshalledTextResult(minimalUser),nil`

Lines changed: 5 additions & 9 deletions

Original file line number	Diff line number	Diff line change
`@@ -224,15 +224,11 @@ func userOrOrgHandler(accountType string, getClient GetClientFn) server.ToolHand`
`224`	`224`
`225`	`225`	`for_,user:=rangeresult.Users {`
`226`	`226`	`ifuser.Login!=nil {`
`227`		`-mu:=MinimalUser{Login:*user.Login}`
`228`		`-ifuser.ID!=nil {`
`229`		`-mu.ID=*user.ID`
`230`		`-}`
`231`		`-ifuser.HTMLURL!=nil {`
`232`		`-mu.ProfileURL=*user.HTMLURL`
`233`		`-}`
`234`		`-ifuser.AvatarURL!=nil {`
`235`		`-mu.AvatarURL=*user.AvatarURL`
	`227`	`+mu:=MinimalUser{`
	`228`	`+Login:user.GetLogin(),`
	`229`	`+ID:user.GetID(),`
	`230`	`+ProfileURL:user.GetHTMLURL(),`
	`231`	`+AvatarURL:user.GetAvatarURL(),`
`236`	`232`	`}`
`237`	`233`	`minimalUsers=append(minimalUsers,mu)`
`238`	`234`	`}`

Comments

(0)