Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

feat(types): addfilter-input to HTMLElementTagNameMap#10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
keithamus merged 1 commit intogithub:mainfromnberlette:feat-tagname-map
Apr 17, 2023

Conversation

nberlette
Copy link
Contributor

@nberlettenberlette commentedApr 17, 2023
edited
Loading

This PR addsfilter-input to the globalHTMLElementTagNameMap interface.

This is essentially the type-level equivalent of adding the tag to the global registry.

Since it is now a globally-recognized element, it's treated as a first class citizen in
the DOM, receiving full type support when using<filter-input> directly in your code,
or adding event listeners, and so on.

Note: today I learned that renaming a branch after opening a PR immediately closes that PR. Sorry for the dupe 😞

Adding `filter-input` to the global `HTMLElementTagNameMap` interface is the type-level equivalent of registering the tag in the global registry. Since it is now recognized as a globally-available element, it enables stronger types when using `<filter-input>` directly, or adding event listeners, etc.
@nberlettenberlette requested a review froma team as acode ownerApril 17, 2023 12:55
@primer-css
Copy link

👋 Hello and thanks for pinging us! This issue or PR has been added to our inbox and a Design Infrastructure first responder will review it soon.

  • 🎨If this is a PR that includes a visual change, please make sure to add screenshots in the description or deploy this code to a lab machine with instructions for how to test.
  • If this is a PR that includes changes to an interaction, please include avideo recording in the description.
  • ⚠️If this is urgent, please visit us in#primer on Slack and tag the first responders listed in the channel topic.

@keithamuskeithamus merged commita2cc735 intogithub:mainApr 17, 2023
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@keithamuskeithamuskeithamus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@nberlette@primer-css@keithamus

[8]ページ先頭

©2009-2025 Movatter.jp