- Notifications
You must be signed in to change notification settings - Fork19
PermalinkChoose a base ref {{ refName }}default Choose a head ref {{ refName }}default
Comparing changes
Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also orlearn more about diff comparisons.
Open a pull request
Create a new pull request by comparing changes across two branches. If you need to, you can also.Learn more about diff comparisons here.
base repository:github/file-attachment-element
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
Uh oh!
There was an error while loading.Please reload this page.
base:v2.0.1
Could not load branches
Nothing to show
Loading
Could not load tags
Nothing to show
{{ refName }}defaultLoading
...
head repository:github/file-attachment-element
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
Uh oh!
There was an error while loading.Please reload this page.
compare:v3.0.0
Could not load branches
Nothing to show
Loading
Could not load tags
Nothing to show
{{ refName }}defaultLoading
- 8commits
- 5files changed
- 2contributors
Commits on Aug 30, 2021
Surface event for file-attachment-dragged
The implementation forgithub/github#190219 needsan event to kick off finding the cursor position, and rather than bubbling theDragEvent it seems prudent to fire a CustomEvent solely used by that consumer.That'll avoid any unintended side effects in the document at large.
Bestra committedAug 30, 2021 Addresses this commenthttps://github.com/github/github/blob/8c9b18cf24713d8be3888f31205ec43ff9f8e7a0/app/assets/modules/github/behaviors/commenting/markdown.ts#L38-L42
Bestra committedAug 30, 2021
Commits on Sep 1, 2021
[pr review] use better name for event target
Bestra committedSep 1, 2021 Bubble original event rather than a new custom one
We decided we could use the `dragover` and `dragenter` events directlyinstead of wrapping them with a custom one. We're still calling `preventDefault()`so we won't accidentally trigger any native behavior downstream.
Bestra committedSep 1, 2021
Commits on Sep 3, 2021
Merge branch 'main' into bestra/file-attachment-dragged-event
koddsson authoredSep 3, 2021 Merge pull request#14from github/bestra/file-attachment-dragged-event
Bubble dragover and dragenter events
koddsson authoredSep 3, 2021
Loading
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:git diff v2.0.1...v3.0.0
Uh oh!
There was an error while loading.Please reload this page.