Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

chore: update rule meta to satisfiy lint rules#621

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
keithamus merged 1 commit intogithub:mainfrom43081j:meta-lints
Mar 19, 2025

Conversation

43081j
Copy link
Contributor

@43081j43081j commentedMar 19, 2025
edited
Loading

Updates a few things in rule meta so the linter is happy:

  • Some descriptions didn't follow the naming convention (enforce,require, etc)
  • Some rules had notype, so these were set toproblem
  • Some rules had norecommended, so these were set to if they are in the recommended config or not
  • Message IDs have been used instead of messages

these didn't happen in CI but did error locally for whatever reason

edit:

so it turns out the eslint-plugin-eslint-plugin rules haven't been running against the rule files

for whatever reason,ast.sourceType ends up as"module" inside the plugin, so it tries to look for ESM exports and doesn't find any. so the rules never run

Updates a few things in rule meta so the linter is happy:- Some descriptions didn't follow the naming convention (`enforce`,  `require`, etc)- Some rules had no `type`, so these were set to `problem`- Some rules had no `recommended`, so these were set to if they are in  the recommended config or not- Message IDs have been used instead of messages
@43081j43081j requested a review froma team as acode ownerMarch 19, 2025 12:42
@43081j43081j mentioned this pull requestMar 19, 2025
Copy link
Contributor

@keithamuskeithamus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

This looks like a great cleanup, thanks so much@43081j!

@keithamuskeithamus merged commit88ccca2 intogithub:mainMar 19, 2025
2 checks passed
@43081j43081j deleted the meta-lints branchMarch 19, 2025 14:35
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@keithamuskeithamuskeithamus approved these changes

@manuelpuyolmanuelpuyolAwaiting requested review from manuelpuyolmanuelpuyol is a code owner automatically assigned from github/web-systems-reviewers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@43081j@keithamus

[8]ページ先頭

©2009-2025 Movatter.jp