- Notifications
You must be signed in to change notification settings - Fork59
Update names back to original for eslint-comments and no-only-tests#605
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
Tip: Copilot code review supports C#, Go, Java, JavaScript, Markdown, Python, Ruby and TypeScript, with more languages coming soon.Learn more
| @@ -17,21 +17,21 @@ module.exports = { | |||
| }, | |||
| plugins: { | |||
| prettierPlugin, | |||
| eslintComments, | |||
| 'eslint-comments':eslintComments, | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Just curious. Why is necessary to revert to the original ones?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
This way we can use the same names in dotcom. Or else we'd have to update the names in the monolith toeslintComments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Thanks for clarifying!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM
a40a2b9 intomainUh oh!
There was an error while loading.Please reload this page.
Updating names back to original for the plugin.