Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Support flat config and upgrade eslint to v9#571

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
gracepark merged 23 commits intomainfromgracepark-support-flat-config
Nov 20, 2024

Conversation

gracepark
Copy link
Contributor

@graceparkgracepark commentedNov 8, 2024
edited by arelia
Loading

This allows us to support flat config and provides testing for both:

  • Upgrades the plugin to v9
  • Flat config
  • Legacy config remains in the same location
  • I've createdtest-examples which allows testing for both legacy and flat configs:
    • For legacy, run:npm run test-examples:legacy on 8.57 without flat config
    • For flat, run:npm run test-examples:flat on 8.57 with flat config

Testing

I usedyalc to test this package with other repos:

  • clipboard-copy-element: This is on v8.42.0 and on legacy eslintrc.json config. I was able to "update" theeslint-plugin-github plugin and rannpm run lint and it ran as expected.
  • codeql-action: eslint is on 8.57.1 and on flat config. I was able to "update" theeslint-plugin-github, rannpm run lint and it ran as expected.

arelia and manuelpuyol reacted with hooray emoji
@graceparkgracepark self-assigned thisNov 12, 2024
@graceparkgracepark marked this pull request as ready for reviewNovember 12, 2024 15:58
@graceparkgracepark requested a review froma team as acode ownerNovember 12, 2024 15:58
@graceparkgracepark changed the titleSupport flat configSupport flat config and upgrade eslint to v9Nov 13, 2024
Copy link
Contributor

@manuelpuyolmanuelpuyol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

This looks great! I love the new test examples and that you tested different repos 😄

@graceparkgracepark merged commit3c52370 intomainNov 20, 2024
7 checks passed
@graceparkgracepark deleted the gracepark-support-flat-config branchNovember 20, 2024 22:49
@areliaarelia linked an issueNov 21, 2024 that may beclosed by this pull request
@turadgturadg mentioned this pull requestDec 7, 2024
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@manuelpuyolmanuelpuyolmanuelpuyol approved these changes

@areliaareliaAwaiting requested review from areliaarelia is a code owner automatically assigned from github/web-systems-reviewers

Assignees

@graceparkgracepark

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for flat config
2 participants
@gracepark@manuelpuyol

[8]ページ先頭

©2009-2025 Movatter.jp