- Notifications
You must be signed in to change notification settings - Fork59
Allow wildcard*.*.* prefix extension#357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
For example, `file-name.server.tsx`, `file-name.d.ts`, `file-name.config.json`This allows any of the following:file-namefile-name.dfile-name.configfile-name.serverfile-name.wild-cardNote that the file extension is not part of the regex.I made this change because we are seeing more and more of this style of 'extension prefix` convention.
33f4e5f toc027e6eComparedgreif approved these changesDec 6, 2022
renovatebot referenced this pull request in WtfJoke/setup-tectonicFeb 4, 2023
[](https://renovatebot.com)This PR contains the following updates:| Package | Change | Age | Adoption | Passing | Confidence ||---|---|---|---|---|---||[eslint-plugin-github](https://togithub.com/github/eslint-plugin-github)| [`4.3.7` ->`4.6.0`](https://renovatebot.com/diffs/npm/eslint-plugin-github/4.3.7/4.6.0)|[](https://docs.renovatebot.com/merge-confidence/)|[](https://docs.renovatebot.com/merge-confidence/)|[](https://docs.renovatebot.com/merge-confidence/)|[](https://docs.renovatebot.com/merge-confidence/)|---### Release Notes<details><summary>github/eslint-plugin-github</summary>###[`v4.6.0`](https://togithub.com/github/eslint-plugin-github/releases/tag/v4.6.0)[CompareSource](https://togithub.com/github/eslint-plugin-github/compare/v4.5.0...v4.6.0)#### What's Changed- Allow wildcard `*.*.*` prefix extension by[@​theinterned](https://togithub.com/theinterned) in[https://github.com/github/eslint-plugin-github/pull/357](https://togithub.com/github/eslint-plugin-github/pull/357)**Full Changelog**:github/eslint-plugin-github@v4.5.0...v4.6.0###[`v4.5.0`](https://togithub.com/github/eslint-plugin-github/releases/tag/v4.5.0)[CompareSource](https://togithub.com/github/eslint-plugin-github/compare/v4.4.1...v4.5.0)#### What's Changed- chore(deps): bump[@​typescript-eslint/parser](https://togithub.com/typescript-eslint/parser)from 5.41.0 to 5.42.0 by[@​dependabot](https://togithub.com/dependabot) in[https://github.com/github/eslint-plugin-github/pull/337](https://togithub.com/github/eslint-plugin-github/pull/337)- chore(deps-dev): bump eslint from 8.26.0 to 8.27.0 by[@​dependabot](https://togithub.com/dependabot) in[https://github.com/github/eslint-plugin-github/pull/339](https://togithub.com/github/eslint-plugin-github/pull/339)- chore(deps): bump[@​typescript-eslint/eslint-plugin](https://togithub.com/typescript-eslint/eslint-plugin)from 5.41.0 to 5.42.0 by[@​dependabot](https://togithub.com/dependabot) in[https://github.com/github/eslint-plugin-github/pull/338](https://togithub.com/github/eslint-plugin-github/pull/338)- chore(deps): bump[@​typescript-eslint/parser](https://togithub.com/typescript-eslint/parser)from 5.42.0 to 5.42.1 by[@​dependabot](https://togithub.com/dependabot) in[https://github.com/github/eslint-plugin-github/pull/342](https://togithub.com/github/eslint-plugin-github/pull/342)- chore(deps-dev): bump chai from 4.3.6 to 4.3.7 by[@​dependabot](https://togithub.com/dependabot) in[https://github.com/github/eslint-plugin-github/pull/341](https://togithub.com/github/eslint-plugin-github/pull/341)- bump[@​typescript-eslint/eslint-plugin](https://togithub.com/typescript-eslint/eslint-plugin)from 5.42.0 to 5.42.1 by[@​dependabot](https://togithub.com/dependabot) in[https://github.com/github/eslint-plugin-github/pull/340](https://togithub.com/github/eslint-plugin-github/pull/340)- chore(deps): bump[@​typescript-eslint/parser](https://togithub.com/typescript-eslint/parser)from 5.42.1 to 5.44.0 by[@​dependabot](https://togithub.com/dependabot) in[https://github.com/github/eslint-plugin-github/pull/348](https://togithub.com/github/eslint-plugin-github/pull/348)- chore(deps): bump[@​typescript-eslint/eslint-plugin](https://togithub.com/typescript-eslint/eslint-plugin)from 5.42.1 to 5.44.0 by[@​dependabot](https://togithub.com/dependabot) in[https://github.com/github/eslint-plugin-github/pull/349](https://togithub.com/github/eslint-plugin-github/pull/349)- chore(deps): bump prettier from 2.7.1 to 2.8.0 by[@​dependabot](https://togithub.com/dependabot) in[https://github.com/github/eslint-plugin-github/pull/347](https://togithub.com/github/eslint-plugin-github/pull/347)- chore(deps): bump[@​typescript-eslint/parser](https://togithub.com/typescript-eslint/parser)from 5.44.0 to 5.45.0 by[@​dependabot](https://togithub.com/dependabot) in[https://github.com/github/eslint-plugin-github/pull/353](https://togithub.com/github/eslint-plugin-github/pull/353)- chore(deps-dev): bump eslint from 8.27.0 to 8.29.0 by[@​dependabot](https://togithub.com/dependabot) in[https://github.com/github/eslint-plugin-github/pull/351](https://togithub.com/github/eslint-plugin-github/pull/351)- chore(deps): bump[@​typescript-eslint/eslint-plugin](https://togithub.com/typescript-eslint/eslint-plugin)from 5.44.0 to 5.45.0 by[@​dependabot](https://togithub.com/dependabot) in[https://github.com/github/eslint-plugin-github/pull/350](https://togithub.com/github/eslint-plugin-github/pull/350)- allow `.server.*` file extension by[@​theinterned](https://togithub.com/theinterned) in[https://github.com/github/eslint-plugin-github/pull/343](https://togithub.com/github/eslint-plugin-github/pull/343)#### New Contributors- [@​theinterned](https://togithub.com/theinterned) made theirfirst contribution in[https://github.com/github/eslint-plugin-github/pull/343](https://togithub.com/github/eslint-plugin-github/pull/343)**Full Changelog**:github/eslint-plugin-github@v4.4.1...v4.5.0###[`v4.4.1`](https://togithub.com/github/eslint-plugin-github/releases/tag/v4.4.1)[CompareSource](https://togithub.com/github/eslint-plugin-github/compare/v4.4.0...v4.4.1)#### What's Changed- Use eslint-plugin-escompat in typescript config by[@​bdragon](https://togithub.com/bdragon) in[https://github.com/github/eslint-plugin-github/pull/326](https://togithub.com/github/eslint-plugin-github/pull/326)- chore(deps): bump[@​typescript-eslint/parser](https://togithub.com/typescript-eslint/parser)from 5.39.0 to 5.40.0 by[@​dependabot](https://togithub.com/dependabot) in[https://github.com/github/eslint-plugin-github/pull/327](https://togithub.com/github/eslint-plugin-github/pull/327)- chore(deps): bump[@​typescript-eslint/eslint-plugin](https://togithub.com/typescript-eslint/eslint-plugin)from 5.39.0 to 5.40.0 by[@​dependabot](https://togithub.com/dependabot) in[https://github.com/github/eslint-plugin-github/pull/329](https://togithub.com/github/eslint-plugin-github/pull/329)- chore(deps-dev): bump mocha from 10.0.0 to 10.1.0 by[@​dependabot](https://togithub.com/dependabot) in[https://github.com/github/eslint-plugin-github/pull/328](https://togithub.com/github/eslint-plugin-github/pull/328)- chore(deps): bump[@​typescript-eslint/parser](https://togithub.com/typescript-eslint/parser)from 5.40.0 to 5.40.1 by[@​dependabot](https://togithub.com/dependabot) in[https://github.com/github/eslint-plugin-github/pull/334](https://togithub.com/github/eslint-plugin-github/pull/334)- chore(deps-dev): bump eslint from 8.25.0 to 8.26.0 by[@​dependabot](https://togithub.com/dependabot) in[https://github.com/github/eslint-plugin-github/pull/333](https://togithub.com/github/eslint-plugin-github/pull/333)- chore(deps): bump eslint-plugin-no-only-tests from 3.0.0 to 3.1.0 by[@​dependabot](https://togithub.com/dependabot) in[https://github.com/github/eslint-plugin-github/pull/332](https://togithub.com/github/eslint-plugin-github/pull/332)- chore(deps): bump eslint-plugin-escompat from 3.3.3 to 3.3.4 by[@​dependabot](https://togithub.com/dependabot) in[https://github.com/github/eslint-plugin-github/pull/331](https://togithub.com/github/eslint-plugin-github/pull/331)- chore(deps): bump[@​typescript-eslint/eslint-plugin](https://togithub.com/typescript-eslint/eslint-plugin)from 5.40.0 to 5.40.1 by[@​dependabot](https://togithub.com/dependabot) in[https://github.com/github/eslint-plugin-github/pull/330](https://togithub.com/github/eslint-plugin-github/pull/330)- chore(deps): bump[@​typescript-eslint/parser](https://togithub.com/typescript-eslint/parser)from 5.40.1 to 5.41.0 by[@​dependabot](https://togithub.com/dependabot) in[https://github.com/github/eslint-plugin-github/pull/335](https://togithub.com/github/eslint-plugin-github/pull/335)- chore(deps): bump[@​typescript-eslint/eslint-plugin](https://togithub.com/typescript-eslint/eslint-plugin)from 5.40.1 to 5.41.0 by[@​dependabot](https://togithub.com/dependabot) in[https://github.com/github/eslint-plugin-github/pull/336](https://togithub.com/github/eslint-plugin-github/pull/336)#### New Contributors- [@​bdragon](https://togithub.com/bdragon) made their firstcontribution in[https://github.com/github/eslint-plugin-github/pull/326](https://togithub.com/github/eslint-plugin-github/pull/326)**Full Changelog**:github/eslint-plugin-github@v4.4.0...v4.4.1###[`v4.4.0`](https://togithub.com/github/eslint-plugin-github/releases/tag/v4.4.0)[CompareSource](https://togithub.com/github/eslint-plugin-github/compare/v4.3.7...v4.4.0)#### What's Changed- chore(deps): bump eslint-plugin-no-only-tests from 2.6.0 to 3.0.0 by[@​dependabot](https://togithub.com/dependabot) in[https://github.com/github/eslint-plugin-github/pull/286](https://togithub.com/github/eslint-plugin-github/pull/286)- chore(deps): bump[@​typescript-eslint/parser](https://togithub.com/typescript-eslint/parser)from 5.30.6 to 5.30.7 by[@​dependabot](https://togithub.com/dependabot) in[https://github.com/github/eslint-plugin-github/pull/285](https://togithub.com/github/eslint-plugin-github/pull/285)- chore(deps): bump[@​typescript-eslint/eslint-plugin](https://togithub.com/typescript-eslint/eslint-plugin)from 5.30.6 to 5.30.7 by[@​dependabot](https://togithub.com/dependabot) in[https://github.com/github/eslint-plugin-github/pull/287](https://togithub.com/github/eslint-plugin-github/pull/287)- chore(deps-dev): bump eslint-plugin-eslint-plugin from 5.0.0 to 5.0.1by [@​dependabot](https://togithub.com/dependabot) in[https://github.com/github/eslint-plugin-github/pull/288](https://togithub.com/github/eslint-plugin-github/pull/288)- chore(deps): bump eslint-plugin-jsx-a11y from 6.6.0 to 6.6.1 by[@​dependabot](https://togithub.com/dependabot) in[https://github.com/github/eslint-plugin-github/pull/289](https://togithub.com/github/eslint-plugin-github/pull/289)- chore(deps): bump prettier from 2.6.2 to 2.7.1 by[@​dependabot](https://togithub.com/dependabot) in[https://github.com/github/eslint-plugin-github/pull/264](https://togithub.com/github/eslint-plugin-github/pull/264)- chore(deps): bump[@​typescript-eslint/eslint-plugin](https://togithub.com/typescript-eslint/eslint-plugin)from 5.30.7 to 5.31.0 by[@​dependabot](https://togithub.com/dependabot) in[https://github.com/github/eslint-plugin-github/pull/291](https://togithub.com/github/eslint-plugin-github/pull/291)- chore(deps): bump[@​typescript-eslint/parser](https://togithub.com/typescript-eslint/parser)from 5.30.7 to 5.31.0 by[@​dependabot](https://togithub.com/dependabot) in[https://github.com/github/eslint-plugin-github/pull/290](https://togithub.com/github/eslint-plugin-github/pull/290)- chore(deps-dev): bump eslint from 8.20.0 to 8.21.0 by[@​dependabot](https://togithub.com/dependabot) in[https://github.com/github/eslint-plugin-github/pull/292](https://togithub.com/github/eslint-plugin-github/pull/292)- chore(deps-dev): bump eslint-plugin-eslint-plugin from 5.0.1 to 5.0.2by [@​dependabot](https://togithub.com/dependabot) in[https://github.com/github/eslint-plugin-github/pull/293](https://togithub.com/github/eslint-plugin-github/pull/293)- chore(deps): bump[@​typescript-eslint/eslint-plugin](https://togithub.com/typescript-eslint/eslint-plugin)from 5.31.0 to 5.32.0 by[@​dependabot](https://togithub.com/dependabot) in[https://github.com/github/eslint-plugin-github/pull/294](https://togithub.com/github/eslint-plugin-github/pull/294)- chore(deps): bump[@​typescript-eslint/parser](https://togithub.com/typescript-eslint/parser)from 5.31.0 to 5.32.0 by[@​dependabot](https://togithub.com/dependabot) in[https://github.com/github/eslint-plugin-github/pull/295](https://togithub.com/github/eslint-plugin-github/pull/295)- chore(deps-dev): bump eslint-plugin-eslint-plugin from 5.0.2 to 5.0.3by [@​dependabot](https://togithub.com/dependabot) in[https://github.com/github/eslint-plugin-github/pull/296](https://togithub.com/github/eslint-plugin-github/pull/296)- chore(deps): bump jsx-ast-utils from 3.3.2 to 3.3.3 by[@​dependabot](https://togithub.com/dependabot) in[https://github.com/github/eslint-plugin-github/pull/298](https://togithub.com/github/eslint-plugin-github/pull/298)- chore(deps): bump[@​typescript-eslint/parser](https://togithub.com/typescript-eslint/parser)from 5.32.0 to 5.33.0 by[@​dependabot](https://togithub.com/dependabot) in[https://github.com/github/eslint-plugin-github/pull/299](https://togithub.com/github/eslint-plugin-github/pull/299)- chore(deps): bump[@​typescript-eslint/eslint-plugin](https://togithub.com/typescript-eslint/eslint-plugin)from 5.32.0 to 5.33.0 by[@​dependabot](https://togithub.com/dependabot) in[https://github.com/github/eslint-plugin-github/pull/300](https://togithub.com/github/eslint-plugin-github/pull/300)- chore(deps-dev): bump eslint from 8.21.0 to 8.22.0 by[@​dependabot](https://togithub.com/dependabot) in[https://github.com/github/eslint-plugin-github/pull/297](https://togithub.com/github/eslint-plugin-github/pull/297)- chore(deps): bump[@​typescript-eslint/eslint-plugin](https://togithub.com/typescript-eslint/eslint-plugin)from 5.33.0 to 5.33.1 by[@​dependabot](https://togithub.com/dependabot) in[https://github.com/github/eslint-plugin-github/pull/301](https://togithub.com/github/eslint-plugin-github/pull/301)- chore(deps): bump[@​typescript-eslint/parser](https://togithub.com/typescript-eslint/parser)from 5.33.0 to 5.33.1 by[@​dependabot](https://togithub.com/dependabot) in[https://github.com/github/eslint-plugin-github/pull/303](https://togithub.com/github/eslint-plugin-github/pull/303)- chore(deps): bump[@​typescript-eslint/parser](https://togithub.com/typescript-eslint/parser)from 5.33.1 to 5.35.1 by[@​dependabot](https://togithub.com/dependabot) in[https://github.com/github/eslint-plugin-github/pull/306](https://togithub.com/github/eslint-plugin-github/pull/306)- chore(deps-dev): bump eslint from 8.22.0 to 8.23.0 by[@​dependabot](https://togithub.com/dependabot) in[https://github.com/github/eslint-plugin-github/pull/305](https://togithub.com/github/eslint-plugin-github/pull/305)- chore(deps): bump[@​typescript-eslint/eslint-plugin](https://togithub.com/typescript-eslint/eslint-plugin)from 5.33.1 to 5.35.1 by[@​dependabot](https://togithub.com/dependabot) in[https://github.com/github/eslint-plugin-github/pull/307](https://togithub.com/github/eslint-plugin-github/pull/307)- chore(deps): bump[@​typescript-eslint/parser](https://togithub.com/typescript-eslint/parser)from 5.35.1 to 5.36.1 by[@​dependabot](https://togithub.com/dependabot) in[https://github.com/github/eslint-plugin-github/pull/308](https://togithub.com/github/eslint-plugin-github/pull/308)- chore(deps): bump[@​typescript-eslint/eslint-plugin](https://togithub.com/typescript-eslint/eslint-plugin)from 5.35.1 to 5.36.1 by[@​dependabot](https://togithub.com/dependabot) in[https://github.com/github/eslint-plugin-github/pull/309](https://togithub.com/github/eslint-plugin-github/pull/309)- chore(deps): bump[@​typescript-eslint/parser](https://togithub.com/typescript-eslint/parser)from 5.36.1 to 5.36.2 by[@​dependabot](https://togithub.com/dependabot) in[https://github.com/github/eslint-plugin-github/pull/310](https://togithub.com/github/eslint-plugin-github/pull/310)- chore(deps): bump[@​typescript-eslint/eslint-plugin](https://togithub.com/typescript-eslint/eslint-plugin)from 5.36.1 to 5.36.2 by[@​dependabot](https://togithub.com/dependabot) in[https://github.com/github/eslint-plugin-github/pull/311](https://togithub.com/github/eslint-plugin-github/pull/311)- chore(deps-dev): bump eslint from 8.23.0 to 8.23.1 by[@​dependabot](https://togithub.com/dependabot) in[https://github.com/github/eslint-plugin-github/pull/312](https://togithub.com/github/eslint-plugin-github/pull/312)- chore(deps): bump[@​typescript-eslint/eslint-plugin](https://togithub.com/typescript-eslint/eslint-plugin)from 5.36.2 to 5.37.0 by[@​dependabot](https://togithub.com/dependabot) in[https://github.com/github/eslint-plugin-github/pull/313](https://togithub.com/github/eslint-plugin-github/pull/313)- chore(deps): bump[@​typescript-eslint/parser](https://togithub.com/typescript-eslint/parser)from 5.36.2 to 5.37.0 by[@​dependabot](https://togithub.com/dependabot) in[https://github.com/github/eslint-plugin-github/pull/314](https://togithub.com/github/eslint-plugin-github/pull/314)- chore(deps): bump[@​typescript-eslint/eslint-plugin](https://togithub.com/typescript-eslint/eslint-plugin)from 5.37.0 to 5.38.0 by[@​dependabot](https://togithub.com/dependabot) in[https://github.com/github/eslint-plugin-github/pull/317](https://togithub.com/github/eslint-plugin-github/pull/317)- chore(deps-dev): bump eslint from 8.23.1 to 8.24.0 by[@​dependabot](https://togithub.com/dependabot) in[https://github.com/github/eslint-plugin-github/pull/316](https://togithub.com/github/eslint-plugin-github/pull/316)- chore(deps): bump[@​typescript-eslint/parser](https://togithub.com/typescript-eslint/parser)from 5.37.0 to 5.38.0 by[@​dependabot](https://togithub.com/dependabot) in[https://github.com/github/eslint-plugin-github/pull/315](https://togithub.com/github/eslint-plugin-github/pull/315)- Update array-foreach.md by[@​rotelloj](https://togithub.com/rotelloj) in[https://github.com/github/eslint-plugin-github/pull/318](https://togithub.com/github/eslint-plugin-github/pull/318)- chore(deps): bump[@​typescript-eslint/eslint-plugin](https://togithub.com/typescript-eslint/eslint-plugin)from 5.38.0 to 5.38.1 by[@​dependabot](https://togithub.com/dependabot) in[https://github.com/github/eslint-plugin-github/pull/319](https://togithub.com/github/eslint-plugin-github/pull/319)- chore(deps): bump[@​typescript-eslint/parser](https://togithub.com/typescript-eslint/parser)from 5.38.0 to 5.38.1 by[@​dependabot](https://togithub.com/dependabot) in[https://github.com/github/eslint-plugin-github/pull/320](https://togithub.com/github/eslint-plugin-github/pull/320)- chore(deps): bump[@​typescript-eslint/parser](https://togithub.com/typescript-eslint/parser)from 5.38.1 to 5.39.0 by[@​dependabot](https://togithub.com/dependabot) in[https://github.com/github/eslint-plugin-github/pull/321](https://togithub.com/github/eslint-plugin-github/pull/321)- chore(deps-dev): bump eslint from 8.24.0 to 8.25.0 by[@​dependabot](https://togithub.com/dependabot) in[https://github.com/github/eslint-plugin-github/pull/322](https://togithub.com/github/eslint-plugin-github/pull/322)- chore(deps): bump[@​typescript-eslint/eslint-plugin](https://togithub.com/typescript-eslint/eslint-plugin)from 5.38.1 to 5.39.0 by[@​dependabot](https://togithub.com/dependabot) in[https://github.com/github/eslint-plugin-github/pull/323](https://togithub.com/github/eslint-plugin-github/pull/323)- Update eslint plugin escompat by[@​koddsson](https://togithub.com/koddsson) in[https://github.com/github/eslint-plugin-github/pull/325](https://togithub.com/github/eslint-plugin-github/pull/325)#### New Contributors- [@​rotelloj](https://togithub.com/rotelloj) made their firstcontribution in[https://github.com/github/eslint-plugin-github/pull/318](https://togithub.com/github/eslint-plugin-github/pull/318)**Full Changelog**:github/eslint-plugin-github@v4.3.7...v4.4.0</details>---### Configuration📅 **Schedule**: Branch creation - "monthly" (UTC), Automerge - At anytime (no schedule defined).🚦 **Automerge**: Enabled.♻ **Rebasing**: Whenever PR becomes conflicted, or you tick therebase/retry checkbox.🔕 **Ignore**: Close this PR and you won't be reminded about this updateagain.---- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, checkthis box---This PR has been generated by [MendRenovate](https://www.mend.io/free-developer-tools/renovate/). Viewrepository job log[here](https://app.renovatebot.com/dashboard#github/WtfJoke/setup-tectonic).<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNC4xMTkuNSIsInVwZGF0ZWRJblZlciI6IjM0LjExOS41In0=-->
%5d(https%3a%2f%2frenovatebot.com){kind=link}
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up to#343
This change updates the recommended eslint config to generalize
filenames/match-regexto allow any "extension prefix". For example,file-name.wild-card.tsThis allows any of the following:
file-namefile-name.dfile-name.configfile-name.serverfile-name.wild-cardNote that the actual file extension is not part of the regex.
I made this change because we are seeing more and more of this style of "extension prefix" convention. In particular I want to enable the
*.server.*file extension introduced inhttps://github.com/github/github/pull/247398.