Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Clarify upgrade process for multi-node environments#39345

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
vgrl merged 3 commits intogithub:mainfromFuzzwah:patch-2
Jul 17, 2025

Conversation

Fuzzwah
Copy link
Contributor

@FuzzwahFuzzwah commentedJul 16, 2025•
edited
Loading

Why:

The docs need to emphasise that the upgrade of the primary needs to fully complete before doing other nodes; trying to upgrade a replica will result in errors if the configuration run hasn't fully completed on the primary.

Check off the following:

  • A subject matter expert (SME) has reviewed the technical accuracy of the content in this PR. In most cases, the author can be the SME. Open source contributions may require an SME review from GitHub staff.
  • The changes in this PR meetthe docs fundamentals that are required for all content.
  • All CI checks are passing and the changes look good in the review environment.

emphasizing that the upgrade of the primary needs to fully complete before doing other nodes.
@CopilotCopilotAI review requested due to automatic review settingsJuly 16, 2025 08:29
Copy link
Contributor

@CopilotCopilotAI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Pull Request Overview

This PR clarifies the upgrade process for multi-node GitHub Enterprise Server environments by strengthening the language around the requirement to wait for the primary node upgrade to fully complete before upgrading other nodes. The change addresses a customer issue where attempting to upgrade replica nodes before the primary's configuration run was complete resulted in upgrade failures.

Key changes:

  • Enhanced guidance text for multi-node upgrade sequencing to emphasize waiting for configuration completion
  • Added explicit warning about upgrade failures when proper sequencing is not followed

@@ -67,7 +67,7 @@ While you can use a hotpatch to upgrade to the latest patch release within a fea

## Upgrading an instance with multiple nodes using an upgrade package

To upgradean instance that comprises multiple nodes using an upgrade package, you must upgrade the primary node, thenupgrade any additional nodes.
To upgradea multi-node GitHub Enterprise Server environment using an upgrade package, you mustfirstupgrade the primary node and wait for its configuration run to complete successfully. Only after the primary is fully upgraded and configured can you proceed toupgrade anyreplica oradditional nodes. Attempting to upgrade other nodes before the primary is complete will result in upgrade failures.
Copy link
Preview

CopilotAIJul 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

The text 'GitHub Enterprise Server' should use the Liquid variable{% data variables.product.prodname_ghe_server %} instead of hardcoded text to ensure consistency and easier global updates.

Copilot uses AI. Check for mistakes.

@github-actionsgithub-actionsbot added the triageDo not begin working on this issue until triaged by the team labelJul 16, 2025
@github-actionsGitHub Actions
Copy link
Contributor

github-actionsbot commentedJul 16, 2025•
edited
Loading

How to review these changes 👓

Thank you for your contribution. To review these changes, choose one of the following options:

A Hubber will need to deploy your changes internally to review.

Table of review links

Note: Please update the URL for your staging server or codespace.

The table shows the files in thecontent directory that were changed in this pull request. This helps you review your changes on a staging server. Changes to thedata directory are not included in this table.

SourceReviewProductionWhat Changed
admin/upgrading-your-instance/performing-an-upgrade/upgrading-with-an-upgrade-package.mdghes@3.173.163.153.14
ghes@3.173.163.153.14

Key:fpt: Free, Pro, Team;ghec: GitHub Enterprise Cloud;ghes: GitHub Enterprise Server

🤖 This comment isautomatically generated.

@Sharra-writesSharra-writes added contentThis issue or pull request belongs to the Docs Content team administering a repoContent relating to administering a repo and removed triageDo not begin working on this issue until triaged by the team labelsJul 16, 2025
@Sharra-writesSharra-writes added the waiting for reviewIssue/PR is waiting for a writer's review labelJul 16, 2025
Copy link
Contributor

@vgrlvgrl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

👍 Thanks for your contribution and keeping these docs updated! 🎉 I'll get this PR merged.

@vgrlvgrl added ready to mergeThis pull request is ready to merge and removed waiting for reviewIssue/PR is waiting for a writer's review labelsJul 17, 2025
@vgrlvgrlenabled auto-mergeJuly 17, 2025 00:27
@vgrlvgrl added this pull request to themerge queueJul 17, 2025
Merged via the queue intogithub:main with commit493b8f8Jul 17, 2025
41 checks passed
@github-actionsGitHub Actions
Copy link
Contributor

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out ourhelp wanted issues ⚡

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

Copilot code reviewCopilotCopilot left review comments

@Sharra-writesSharra-writesSharra-writes left review comments

@vgrlvgrlvgrl approved these changes

Assignees
No one assigned
Labels
administering a repoContent relating to administering a repocontentThis issue or pull request belongs to the Docs Content teamready to mergeThis pull request is ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@Fuzzwah@vgrl@Sharra-writes
[8]ページ先頭
©2009-2025 Movatter.jp