- Notifications
You must be signed in to change notification settings - Fork62.5k
Repo sync#39315
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Conversation
Co-authored-by: Joe Clark <31087804+jc-clark@users.noreply.github.com>
Co-authored-by: mc <42146119+mchammer01@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
2758eba intomainUh oh!
There was an error while loading.Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Pull Request Overview
This is an automated pull request to sync changes between the public and private repos. The PR contains multiple updates to API documentation data files, including updated descriptions, new fields, and configuration updates.
- Updates to GitHub Advanced Security descriptions across multiple API schema files
- Addition of new fields for organization membership and release immutability
- Updates to secret scanning patterns and search component improvements
Reviewed Changes
Copilot reviewed 60 out of 66 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/webhooks/lib/config.json | Updates SHA reference for webhook configuration |
| src/webhooks/data/ghes-*/schema.json | Adds descriptions for Advanced Security parameters and new membership/release fields |
| src/types.ts | Adds new properties to Permalink and Page types |
| src/secret-scanning/lib/config.json | Updates SHA references for secret scanning configuration |
| src/secret-scanning/data/public-docs.yml | Adds new Val Town API token pattern and enables push protection for WebDriver API key |
| src/search/components/input/*.tsx | React component updates for search functionality with key prop fixes |
| src/rest/lib/config.json | Updates SHA reference for REST API configuration |
| src/rest/data/ghes-*/schema.json | Adds Advanced Security descriptions and new API fields across multiple versions |
| @@ -42,15 +49,20 @@ export function SearchBarButton({ isSearchOpen, setIsSearchOpen, params, searchB | |||
| const placeHolderElements = t('search.input.placeholder') | |||
| .split(/({{[^}]+}})/) | |||
| .filter((item) => item.trim() !== '') | |||
| .map((item) => <>{item.trim()}</>) | |||
| placeHolderElements[1] = <CopilotIcon aria-hidden className="mr-1 ml-1" /> | |||
| .map((item, index) => <span key={`${item.trim()}-${index}`}>{item.trim()}</span>) | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
[nitpick] Using array index as part of the React key can cause issues if the array order changes. Consider using a more stable identifier or just the trimmed content if it's unique.
| .map((item,index)=><spankey={`${item.trim()}-${index}`}>{item.trim()}</span>) | |
| .map((item)=><spankey={item.trim()}>{item.trim()}</span>) |
Copilot uses AI. Check for mistakes.
| .map((item, index) => <span key={`${item.trim()}-${index}`}>{item.trim()}</span>) | ||
| placeHolderElements[1] = <CopilotIconkey="copilot-icon"aria-hidden className="mr-1 ml-1" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Direct array index assignment after mapping can be fragile. The assumption that index 1 exists and should be the icon might not hold if the placeholder text structure changes.
| .map((item,index)=><spankey={`${item.trim()}-${index}`}>{item.trim()}</span>) | |
| placeHolderElements[1]=<CopilotIconkey="copilot-icon"aria-hiddenclassName="mr-1 ml-1"/> | |
| .map((item,index)=> | |
| item.trim()==='{{icon}}' | |
| ?<CopilotIconkey="copilot-icon"aria-hiddenclassName="mr-1 ml-1"/> | |
| :<spankey={`${item.trim()}-${index}`}>{item.trim()}</span> | |
| ) |
Copilot uses AI. Check for mistakes.
This is an automated pull request to sync changes between the public and private repos.
Our bot will merge this pull request automatically.
To preserve continuity across repos,do not squash this pull request.