NotificationsYou must be signed in to change notification settings
Fork62.5k
Star17.6k

enhance(avoiding-duplication): secrets comparison accuracy#39062

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Open

Malix-Labs wants to merge1 commit intogithub:main

base:main

Choose a base branch

fromMalix-Labs:patch-3

Open

enhance(avoiding-duplication): secrets comparison accuracy#39062

Malix-Labs wants to merge1 commit intogithub:mainfromMalix-Labs:patch-3

Conversation

Copy link

Contributor

Malix-Labs commentedJun 26, 2025

Why:

The secret comparison between reusable workflows and composite actions was inaccurate

What's being changed (if available, include any code snippets, screenshots, or gifs):

Enhancing the accuracy of the secret comparison between reusable workflows and composite actions

Check off the following:

A subject matter expert (SME) has reviewed the technical accuracy of the content in this PR. In most cases, the author can be the SME. Open source contributions may require an SME review from GitHub staff.
The changes in this PR meetthe docs fundamentals that are required for all content.
All CI checks are passing and the changes look good in the review environment.

enhance(avoiding-duplication): secrets comparison accuracy

2ccead0

CopilotAI review requested due to automatic review settings

June 26, 2025 19:08

CopilotAI reviewed

Jun 26, 2025

View reviewed changes

Copy link

Contributor

CopilotAI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Pull Request Overview

This PR improves the accuracy of the secret comparison between reusable workflows and composite actions.

Updated the table entry for secrets to reflect that secrets must be passed explicitly as named secrets for reusable workflows and as inputs for composite actions.

Comments suppressed due to low confidence (1)

content/actions/concepts/workflows-and-actions/avoiding-duplication.md:47

[nitpick] Ensure that the updated language for secret handling remains consistent with the broader documentation style and guidelines for describing secret passing methods.

| Secrets must be passed as explicit named secrets | Secrets must be passed as inputs from the calling workflow |

github-actionsbot added the triageDo not begin working on this issue until triaged by the team label

Jun 26, 2025

Copy link

Contributor

github-actionsbot commentedJun 26, 2025

How to review these changes 👓

Thank you for your contribution. To review these changes, choose one of the following options:

A Hubber will need to deploy your changes internally to review.

Table of review links

Note: Please update the URL for your staging server or codespace.

The table shows the files in thecontent directory that were changed in this pull request. This helps you review your changes on a staging server. Changes to thedata directory are not included in this table.