NotificationsYou must be signed in to change notification settings
Fork62.5k
Star17.6k

Add documentation on`on.workflow_run.workflows`#37022

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Open

EnricoMi wants to merge3 commits intogithub:main

base:main

Choose a base branch

fromEnricoMi:workflow_run-workflows

Open

Add documentation on`on.workflow_run.workflows`#37022

EnricoMi wants to merge3 commits intogithub:mainfromEnricoMi:workflow_run-workflows

+36 −1

Conversation

Copy link

EnricoMi commentedMar 21, 2025•
edited
Loading

Why:

The values ofon.workflow_run.workflows are treated as glob patterns. Special characters requires escaping.

Details:
https://github.com/orgs/community/discussions/50835
actions/runner#3763

Closes:#12572

What's being changed (if available, include any code snippets, screenshots, or gifs):

Adds documentation foron.workflow_run.workflows, especially around glob patterns.

Check off the following:

A subject matter expert (SME) has reviewed the technical accuracy of the content in this PR. In most cases, the author can be the SME. Open source contributions may require an SME review from GitHub staff.
The changes in this PR meetthe docs fundamentals that are required for all content.
All CI checks are passing and the changes look good in the review environment.

Add documentation on workflow_run.workflows

4cfe076

Copy link

welcomebot commentedMar 21, 2025

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out thecontributing guidelines.

EnricoMi mentioned this pull request

Mar 21, 2025

Documentworkflow_run behaviour when workflow name contains special characters#12572

Closed

1 task

github-actionsbot added the triageDo not begin working on this issue until triaged by the team label

Mar 21, 2025

Copy link

Contributor

github-actionsbot commentedMar 21, 2025•
edited
Loading

How to review these changes 👓

Thank you for your contribution. To review these changes, choose one of the following options:

A Hubber will need to deploy your changes internally to review.

Table of review links

⚠️Warning: Our review server is experiencing latency issues.

The table shows the files in thecontent directory that were changed in this pull request. This helps you review your changes on the review server. Changes to thedata directory are not included in this table.

Source	Review	Production	What Changed
`actions/writing-workflows/workflow-syntax-for-github-actions.md`	fpt ghec ghes@3.16 3.15 3.14 3.13 3.12	fpt ghec ghes@3.16 3.15 3.14 3.13 3.12

Key:fpt: Free, Pro, Team;ghec: GitHub Enterprise Cloud;ghes: GitHub Enterprise Server

🤖 This comment isautomatically generated.

EnricoMi mentioned this pull request

Mar 21, 2025

Aon.workflow_run.workflows containing+ not supportedactions/runner#3763

Closed

EnricoMi changed the title~~Add documentation on workflow_run.workflows~~Add documentation onon.workflow_run.workflows

Mar 21, 2025

Sharra-writes added content

This issue or pull request belongs to the Docs Content team

needs SMEThis proposal needs review from a subject matter expert and removed triageDo not begin working on this issue until triaged by the team labels

Mar 21, 2025

Copy link

Contributor

github-actionsbot commentedMar 21, 2025

Thanks for opening a pull request! We've triaged this issue for technical review by a subject matter expert 👀

Copy link

Contributor

Sharra-writes commentedMar 21, 2025

Thanks so much for opening a PR! I'll get this triaged for review.

Copy link

Contributor

Sharra-writes commentedMar 24, 2025

Hi,@EnricoMi. 👋 One of the team wanted to make sure you had seenthis while we're waiting for feedback from our SMEs on this issue.

Copy link

Author

EnricoMi commentedMar 25, 2025

@Sharra-writes thanks for the reply! Please let the team know that I do not see the connection between the DockerfileWORKDIR option and how Github Actions evaluates values foron.workflow_run.workflow.

Copy link

Contributor

Sharra-writes commentedMar 26, 2025•
edited
Loading

@EnricoMi Well, no wonder it doesn't seem relevant, because I got my tabs mixed up and put this on the wrong pull request. 😅 I'm so sorry, and thank you for being patient with us. I do have this open for the SMEs to look at.

Copy link

Contributor

subatoi commentedMar 27, 2025

Hi@EnricoMi, thanks for raising this—I'm going to reopen the original issue so we can transfer it internally.

We'll schedule this work as soon as we can. Just so you're aware, there's a few moving parts to this and I can't guarantee that we'll use this PR: since we need to make some further changes, it may be easier for us to start a new one instead. If we do that, would you like us to add you as a co-committer? I notice you're notusingnoreply on your email address in your commits.

Many thanks