- Notifications
You must be signed in to change notification settings - Fork1.1k
every curl needs optional s, and admin port#859
Uh oh!
There was an error while loading.Please reload this page.
Conversation
I know we warn about this in a tip in the top, but it's so subtle and easily missed. Is there any reason not to include this elsewhere?
also, just noticed the tip at the top of the page, but it's SO easy to miss. I guess alternatively you could change the |
I'm definitely in favor of adding the I'm not so sure about the |
@gjtorikian not to mention, languages. maybe it'd look weird for certain people. If the port is 8080, it should be known from set up that it's http, and 8443 for https. That's a decent compromise 😉 |
@gjtorikian i think we're set on this if you want to give it another look. I also noticed some response |
leefaus commentedSep 14, 2015
👍 Thanks to all for helping on this. I think this will make it easier for enterprise customers to consume these endpoints. |
| @@ -24,13 +24,13 @@ You need to pass your [Management Console password](https://help.github.com/ente | |||
| Use the `api_key` parameter to send this token with each request. For example: | |||
| <pre class="terminal"> | |||
| $ curl -L 'http://<em>hostname</em>/setup/api?api_key=<em>your-amazing-password</em>' | |||
| $ curl -L 'http://<em>hostname</em>:<em>admin_port</em>:<em>admin_port</em>/setup/api?api_key=<em>your-amazing-password</em>' | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Duplicated port info.
One tiny comment; when that's fixed feel free to merge. Thanks! |
@gjtorikian great catch! updated |
@gjtorikian just caught something, in other examples for enterprise, we put |
Hmm. Since it's pointing to api.github.com, can we be bold and just switch 'em to |
leefaus commentedSep 17, 2015
Since the APIs are based on GitHub.com and on Enterprise customers, I think it would be valuable to call out both http and https as appropriate. |
@gjtorikian can I get your 👍 on this if it is good with@leefaus' final comments? It looks like you have that last piece of outstanding feedback. 😄 |
| @@ -24,13 +24,13 @@ You need to pass your [Management Console password](https://help.github.com/ente | |||
| Use the `api_key` parameter to send this token with each request. For example: | |||
| <pre class="terminal"> | |||
| $ curl -L 'http://<em>hostname</em>/setup/api?api_key=<em>your-amazing-password</em>' | |||
| $ curl -L 'http://<em>hostname</em>:<em>admin_port</em>/setup/api?api_key=<em>your-amazing-password</em>' | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Maybeconsole_port or mentionadmin_port specifically above?
I'm definitely against the existing I firmly believe The Right Thing to Do™ is:
|
every curl needs optional s, and admin port
Thanks@gjtorikian! I merged this PR so you can tackle that work separately. |
I know we warn about this in a tip in the top, but it's so subtle and easily missed. Is there any reason not to include this elsewhere? cc@leefaus who was helping me with this!
cc @github/docs or@gjtorikian