- Notifications
You must be signed in to change notification settings - Fork1.1k
Makeing it clear where the presented code goes#820
Uh oh!
There was an error while loading.Please reload this page.
Conversation
kdaigle commentedJul 27, 2015
I'm not exactly clear on what "code" you're talking about here. Are you looking for some language to state that you should check the scopes after you receive the |
edusantana commentedJul 27, 2015
When I was reading it I didn't know where to put the fowling code: #!ruby# check if we were granted user:email scopescopes=JSON.parse(result)['scope'].split(',')has_user_email_scope=scopes.include?'user:email' It goes right AFTER the line: access_token = JSON.parse(result)['access_token'] |
edusantana commentedJul 27, 2015
I have added the text so that others would know it, but feel free to reject if it's not a good ideia. |
kdaigle commentedJul 28, 2015
@edusantana ah, now I see what you mean. 😄 I'll update the docs by clarifying where that code should live by changing the actual code block. I'm going to close this PR as I'd like to document this differently than you have but thanks so much for the suggestion! |
jasonrudolph commentedJul 28, 2015
@edusantana: Thanks for letting us know that this part of the docs needed improvement. We've updated the docs in#829. |
Reinsert missing definition lists
The guide doesn't show where the presented code goes.