Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings
This repository was archived by the owner on Nov 1, 2017. It is now read-only.

Fix verbs description concerning custom actions#685

Merged

Conversation

fixe
Copy link
Contributor

Fromthe documentation:

PUT /repos/:owner/:repo/pulls/:number/merge

Custom actions are usingPUT instead ofPOST.

@izuzak
Copy link
Member

Thanks for pointing that out,@fixe! ⚡

This might just be a bad example (possibly here from a previous version of the API). I wouldn't say that PUT is used for custom actions -- a POST method is almost always used for that (not just in the GitHub API). A better example for this might berendering a Markdown document ormerging branches.

What do you think,@pengwynn@jasonrudolph?

@fixe
Copy link
ContributorAuthor

@izuzakstarring a repository is also done with aPUT:

PUT /gists/:id/star

@pengwynn
Copy link
Contributor

I think we can just drop the "and performing custom actions (such as merging a pull request)." part.

In both themerge andstar examples, those aren't verbs, they're nouns. You're creating a merge or creating a star, and there can only be one at that resource location.

@fixefixeforce-pushed thesupport/fix-verbs-description branch froma795aa8 toeae5da8CompareJanuary 12, 2015 14:55
@fixe
Copy link
ContributorAuthor

@pengwynn PR updated.

pengwynn added a commit that referenced this pull requestJan 12, 2015
Fix verbs description concerning custom actions
@pengwynnpengwynn merged commit84e6615 intogithub:masterJan 12, 2015
@pengwynn
Copy link
Contributor

🍰

@fixefixe deleted the support/fix-verbs-description branchJanuary 12, 2015 15:58
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@fixe@izuzak@pengwynn

[8]ページ先頭

©2009-2025 Movatter.jp