This repository was archived by the owner on Nov 1, 2017. It is now read-only.
- Notifications
You must be signed in to change notification settings - Fork1.1k
Create OAuth token with repo and user scope in getting started guide#684
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
…"user" scopeReaders may confuse when they create OAuth token following the examplecurl command instead on the web form and noticed that the "plan" userdata field not displayed even when they're authenticated successfullydue to the missing "user" scope access.This commit fixes this issue by also request "repo", "public_repo","user", and "gist" scope in the Oauth token command-line request casesthus the result will be same with the one using GitHub's webform.This change may needs further lingual and cosmetic patches to make itwell-looking enough.Signed-off-by: Ｖ字龍(Vdragon) <Vdragon.Taiwan@gmail.com>
…ion-in-content-guides-getting-started
Contributor
gjtorikian commentedJan 12, 2015
Nice. 👍 |
izuzak added a commit that referenced this pull requestJan 13, 2015
…eededCreate OAuth token with repo and user scope in getting started guide
Contributor
Vdragon commentedJan 13, 2015
Currently I've no time to review the change, but I'll give a 👍 anyway. |
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a second attempt at#630. It's basically the same, butdrops the
gistandpublic_reposcopes which are not used (gist) or are included in other scopes (public_repois included inrepo).What do you think,@Vdragon and@gjtorikian?