This repository was archived by the owner on Nov 1, 2017. It is now read-only.
- Notifications
You must be signed in to change notification settings - Fork1.1k
Fix confusing about missing "plan" field of user data due to missing "user" scope#630
Closed
Vdragon wants to merge1 commit intogithub:masterfromVdragon:fix-possible-confusion-in-content-guides-getting-started
Closed
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
…"user" scopeReaders may confuse when they create OAuth token following the examplecurl command instead on the web form and noticed that the "plan" userdata field not displayed even when they're authenticated successfullydue to the missing "user" scope access.This commit fixes this issue by also request "repo", "public_repo","user", and "gist" scope in the Oauth token command-line request casesthus the result will be same with the one using GitHub's webform.This change may needs further lingual and cosmetic patches to make itwell-looking enough.Signed-off-by: Ｖ字龍(Vdragon) <Vdragon.Taiwan@gmail.com>
Member
izuzak commentedOct 30, 2014
@Vdragon Thanks for taking the time to submit feedbackand create a pull request! ✨ Since If you're okay with making that modification, let me know after you've done so and I'd be happy to merge this. Thanks again! |
Member
izuzak commentedJan 10, 2015
Closing in favor of#684. |
gjtorikian added a commit that referenced this pull requestOct 9, 2015
Add endpoint for unlocking repository
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Readers may confuse when they create OAuth token following the example
curl command instead on the web form and noticed that the "plan" user
data field not displayed even when they're authenticated successfully
due to the missing "user" scope access.
This commit fixes this issue by also request "repo", "public_repo",
"user", and "gist" scope in the Oauth token command-line request cases
thus the result will be same with the one using GitHub's webform.
NOTE that this change may needs further lingual and cosmetic patches to make it
well-looking enough.
Signed-off-by: Ｖ字龍(Vdragon)Vdragon.Taiwan@gmail.com