- Notifications
You must be signed in to change notification settings - Fork1.1k
Fix reference to default IRC hook events.#496
Uh oh!
There was an error while loading.Please reload this page.
Conversation
izuzak commentedMay 3, 2014
I agree that this is confusing and +1 on clarifying this -- thanks for tackling this 📖,@jdpace ! 💟 I'm not that familiar with how services work so I might very well be wrong on this, but there might be confusion around what the hook listens to by default vs what it can listen to if configured manually. By default, itlistens to just the If my understanding is correct, what do you think about clarifying this difference? |
jdpace commentedMay 3, 2014
Correct, a service may support many more events besides it's default set. Services set up via the UI only get the default set specified in the service file (or |
izuzak commentedMay 3, 2014
@jdpace How about something like this:
Not sure if this is helpful -- I'm finding it hard to write a clear explanation. 😓 |
jdpace commentedMay 5, 2014
IRC actually supports several more than that which might lead to more confusion. Here's a couple of other popular services which only support a limited number of events:
"Webhooks UI" isn't the right term here. "UI" is more correct but might not be specific enough. |
yocopoco1 commentedMay 5, 2014
Hallo Von Samsung Mobile gesendet -------- Ursprüngliche Nachricht -------- For example, the Web service supports listening for all events, while the IRC service can listen for push, issues and pull_request events. IRC actually supports several more than that which might lead to more confusion. Here's a couple of other popular services which only support a limited number of events: Twitter - push "Webhooks UI" isn't the right term here. "UI" is more correct but might not be specific enough. — |
content/webhooks/index.md Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
izuzak commentedMay 8, 2014
@jdpace Thanks for pointing those things out. 🙇 Here's a new version which takes those two things into account:
What do you think? |
jdpace commentedMay 9, 2014
@izuzak That looks great to me 📖 ✨ |
izuzak commentedMay 9, 2014
Cool, I updated the PR with that text. 👯 |
…-eventsFix reference to default IRC hook events.
Oauth token deprecation migration period
IRC hooks only listen to
pushandpull_requestevents by default. This was causing confusion for users who were expecting to receiveissuesevents as well.There may be a better hook to use as an example since the list of supported events for the IRC hooks varies so much from the default set.